RUBY-2254 sort by id when comparing collection contents (#2823)

Author: jamis

spec/mongo/collection_crud_spec.rb

@@ -2491,7 +2491,7 @@ def generate
       end
 
       let(:updated) do
-        authorized_collection.find.to_a.last
+        authorized_collection.find.sort(_id: 1).to_a.last
       end
 
       it 'reports that a document was written' do

spec/mongo/operation/insert_spec.rb

@@ -177,7 +177,7 @@
         end
 
         it 'inserts the documents into the collection' do
-          expect(authorized_collection.find.to_a). to eq(documents)
+          expect(authorized_collection.find.sort(_id: 1).to_a). to eq(documents)
         end
       end
 

spec/runners/crud.rb

@@ -26,7 +26,7 @@
 require 'runners/crud/verifier'
 
 def collection_data(collection)
-  collection.find.to_a
+  collection.find.sort(_id: 1).to_a
 end
 
 def crud_execute_operations(spec, test, num_ops, event_subscriber, expect_error,

spec/runners/crud/test.rb

@@ -110,14 +110,6 @@ def setup_test(spec, client)
         end
         setup_fail_point(client)
       end
-
-      def actual_collection_contents(client)
-        unless @spec.collection_name
-          raise ArgumentError, 'Spec does not specify a global collection'
-        end
-
-        client[@spec.collection_name, read_concern: {level: :majority}].find.to_a
-      end
     end
   end
 end