Refactor

Author: aclark4life

pymongo/asynchronous/srv_resolver.py

@@ -129,19 +129,19 @@ async def _get_srv_response_and_hosts(
     ) -> tuple[resolver.Answer, list[tuple[str, Any]]]:
         results = await self._resolve_uri(encapsulate_errors)
 
-        if self.__fqdn == results[0].target.to_text():
-            raise ConfigurationError(
-                "Invalid SRV host: return address is identical to SRV hostname"
-            )
-
         # Construct address tuples
         nodes = [
             (maybe_decode(res.target.to_text(omit_final_dot=True)), res.port)  # type: ignore[attr-defined]
             for res in results
         ]
 
         # Validate hosts
+        srv_host = results[0].target.to_text()
         for node in nodes:
+            if self.__fqdn == srv_host:
+                raise ConfigurationError(
+                    "Invalid SRV host: return address is identical to SRV hostname"
+                )
             try:
                 nlist = node[0].lower().split(".")[1:][-self.__slen :]
             except Exception:

pymongo/synchronous/srv_resolver.py

@@ -129,19 +129,19 @@ def _get_srv_response_and_hosts(
     ) -> tuple[resolver.Answer, list[tuple[str, Any]]]:
         results = self._resolve_uri(encapsulate_errors)
 
-        if self.__fqdn == results[0].target.to_text():
-            raise ConfigurationError(
-                "Invalid SRV host: return address is identical to SRV hostname"
-            )
-
         # Construct address tuples
         nodes = [
             (maybe_decode(res.target.to_text(omit_final_dot=True)), res.port)  # type: ignore[attr-defined]
             for res in results
         ]
 
         # Validate hosts
+        srv_host = results[0].target.to_text()
         for node in nodes:
+            if self.__fqdn == srv_host:
+                raise ConfigurationError(
+                    "Invalid SRV host: return address is identical to SRV hostname"
+                )
             try:
                 nlist = node[0].lower().split(".")[1:][-self.__slen :]
             except Exception: