Addresses comments.

Author: caseyclements

bson/binary.py

@@ -532,7 +532,7 @@ def as_vector(self) -> BinaryVector:
             unpacked_uint8s = list(struct.unpack_from(format_string, self, position))
             if padding and n_values and unpacked_uint8s[-1] & (1 << padding) - 1 != 0:
                 warnings.warn(
-                    "Vector has a padding P, but bits in the final byte lower than P are non-zero. In the next major version, they must be zero.",
+                    "Vector has a padding P, but bits in the final byte lower than P are non-zero. For pymongo>=5.0, they must be zero.",
                     DeprecationWarning,
                     stacklevel=2,
                 )

test/test_bson.py

@@ -784,20 +784,12 @@ def test_vector(self):
 
         # Now some invalid cases
         for x in [-1, 257]:
-            try:
+            with self.assertRaises(struct.error):
                 Binary.from_vector([x], BinaryVectorDtype.PACKED_BIT)
-            except Exception as exc:
-                self.assertIsInstance(exc, struct.error)
-            else:
-                self.fail("Failed to raise an exception.")
 
         # Test one must pass zeros for all ignored bits
-        try:
+        with self.assertRaises(ValueError):
             Binary.from_vector([255], BinaryVectorDtype.PACKED_BIT, padding=7)
-        except Exception as exc:
-            self.assertIsInstance(exc, ValueError)
-        else:
-            self.fail("Failed to raise an exception.")
 
         # Test form of Binary.from_vector(BinaryVector)
         assert padded_vec == Binary.from_vector(