Pass ServerDescription.__repr__ to SDAM logging

Author: NoahStapp

pymongo/asynchronous/topology.py

@@ -154,8 +154,8 @@ def __init__(self, topology_settings: TopologySettings):
                 _SDAM_LOGGER,
                 message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
                 topologyId=self._topology_id,
-                previousDescription=initial_td,
-                newDescription=self._description,
+                previousDescription=initial_td.__repr__(),
+                newDescription=self._description.__repr__(),
             )
 
         for seed in topology_settings.seeds:
@@ -514,8 +514,8 @@ async def _process_change(
                 _SDAM_LOGGER,
                 message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
                 topologyId=self._topology_id,
-                previousDescription=td_old,
-                newDescription=self._description,
+                previousDescription=td_old.__repr__(),
+                newDescription=self._description.__repr__(),
             )
 
         # Shutdown SRV polling for unsupported cluster types.
@@ -581,8 +581,8 @@ async def _process_srv_update(self, seedlist: list[tuple[str, Any]]) -> None:
                 _SDAM_LOGGER,
                 message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
                 topologyId=self._topology_id,
-                previousDescription=td_old,
-                newDescription=self._description,
+                previousDescription=td_old.__repr__(),
+                newDescription=self._description.__repr__(),
             )
 
     async def on_srv_update(self, seedlist: list[tuple[str, Any]]) -> None:
@@ -747,8 +747,8 @@ async def close(self) -> None:
                 _SDAM_LOGGER,
                 message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
                 topologyId=self._topology_id,
-                previousDescription=old_td,
-                newDescription=self._description,
+                previousDescription=old_td.__repr__(),
+                newDescription=self._description.__repr__(),
             )
             _debug_log(
                 _SDAM_LOGGER, message=_SDAMStatusMessage.STOP_TOPOLOGY, topologyId=self._topology_id

pymongo/synchronous/topology.py

@@ -154,8 +154,8 @@ def __init__(self, topology_settings: TopologySettings):
                 _SDAM_LOGGER,
                 message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
                 topologyId=self._topology_id,
-                previousDescription=initial_td,
-                newDescription=self._description,
+                previousDescription=initial_td.__repr__(),
+                newDescription=self._description.__repr__(),
             )
 
         for seed in topology_settings.seeds:
@@ -514,8 +514,8 @@ def _process_change(
                 _SDAM_LOGGER,
                 message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
                 topologyId=self._topology_id,
-                previousDescription=td_old,
-                newDescription=self._description,
+                previousDescription=td_old.__repr__(),
+                newDescription=self._description.__repr__(),
             )
 
         # Shutdown SRV polling for unsupported cluster types.
@@ -581,8 +581,8 @@ def _process_srv_update(self, seedlist: list[tuple[str, Any]]) -> None:
                 _SDAM_LOGGER,
                 message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
                 topologyId=self._topology_id,
-                previousDescription=td_old,
-                newDescription=self._description,
+                previousDescription=td_old.__repr__(),
+                newDescription=self._description.__repr__(),
             )
 
     def on_srv_update(self, seedlist: list[tuple[str, Any]]) -> None:
@@ -745,8 +745,8 @@ def close(self) -> None:
                 _SDAM_LOGGER,
                 message=_SDAMStatusMessage.TOPOLOGY_CHANGE,
                 topologyId=self._topology_id,
-                previousDescription=old_td,
-                newDescription=self._description,
+                previousDescription=old_td.__repr__(),
+                newDescription=self._description.__repr__(),
             )
             _debug_log(
                 _SDAM_LOGGER, message=_SDAMStatusMessage.STOP_TOPOLOGY, topologyId=self._topology_id

test/asynchronous/test_client.py

@@ -1906,7 +1906,6 @@ async def test_direct_connection(self):
         with self.assertRaises(ConfigurationError):
             AsyncMongoClient(["host1", "host2"], directConnection=True)
 
-    @unittest.skipIf(os.environ.get("DEBUG_LOG"), "Enabling debug logs breaks this test")
     @unittest.skipIf("PyPy" in sys.version, "PYTHON-2927 fails often on PyPy")
     async def test_continuous_network_errors(self):
         def server_description_count():

test/test_client.py

@@ -1863,7 +1863,6 @@ def test_direct_connection(self):
         with self.assertRaises(ConfigurationError):
             MongoClient(["host1", "host2"], directConnection=True)
 
-    @unittest.skipIf(os.environ.get("DEBUG_LOG"), "Enabling debug logs breaks this test")
     @unittest.skipIf("PyPy" in sys.version, "PYTHON-2927 fails often on PyPy")
     def test_continuous_network_errors(self):
         def server_description_count():