PYTHON-2345 Ensure release files can be installed (#487)

Author: ShaneHarvey

.evergreen/build-mac.sh

@@ -1,5 +1,13 @@
 #!/bin/bash -ex
 
+# Get access to testinstall.
+. .evergreen/utils.sh
+
+# Create temp directory for validated files.
+rm -rf validdist
+mkdir -p validdist
+mv dist/* validdist || true
+
 for VERSION in 2.7 3.4 3.5 3.6 3.7 3.8; do
     if [[ $VERSION == "2.7" ]]; then
         PYTHON=/System/Library/Frameworks/Python.framework/Versions/2.7/bin/python
@@ -9,7 +17,27 @@ for VERSION in 2.7 3.4 3.5 3.6 3.7 3.8; do
         PYTHON=/Library/Frameworks/Python.framework/Versions/$VERSION/bin/python3
     fi
     rm -rf build
-    $PYTHON setup.py bdist_wheel
+
+    # Install wheel if not already there.
+    if ! $PYTHON -m wheel version; then
+        createvirtualenv $PYTHON releasevenv
+        WHEELPYTHON=python
+        pip install --upgrade wheel
+    else
+        WHEELPYTHON=$PYTHON
+    fi
+
+    $WHEELPYTHON setup.py bdist_wheel
+    deactivate || true
+    rm -rf releasevenv
+
+    # Test that each wheel is installable.
+    for release in dist/*; do
+        testinstall $PYTHON $release
+        mv $release validdist/
+    done
 done
 
+mv validdist/* dist
+rm -rf validdist
 ls dist

.evergreen/build-manylinux-internal.sh

@@ -1,25 +1,42 @@
 #!/bin/bash -ex
-cd /pymongo
+cd /src
+
+# Get access to testinstall.
+. .evergreen/utils.sh
+
+# Create temp directory for validated files.
+rm -rf validdist
+mkdir -p validdist
+mv dist/* validdist || true
 
 # Compile wheels
-for PYBIN in /opt/python/*/bin; do
+for PYTHON in /opt/python/*/bin/python; do
     # Skip Python 3.3 and 3.9.
-    if [[ "$PYBIN" == *"cp33"* || "$PYBIN" == *"cp39"* ]]; then
+    if [[ "$PYTHON" == *"cp33"* || "$PYTHON" == *"cp39"* ]]; then
         continue
     fi
     # https://github.com/pypa/manylinux/issues/49
     rm -rf build
-    ${PYBIN}/python setup.py bdist_wheel
-done
+    $PYTHON setup.py bdist_wheel
+    rm -rf build
 
-# https://github.com/pypa/manylinux/issues/49
-rm -rf build
+    # Audit wheels and write multilinux tag
+    for whl in dist/*.whl; do
+        # Skip already built manylinux1 wheels.
+        if [[ "$whl" != *"manylinux"* ]]; then
+            auditwheel repair $whl -w dist
+            rm $whl
+        fi
+    done
 
-# Audit wheels and write multilinux1 tag
-for whl in dist/*.whl; do
-    # Skip already built manylinux1 wheels.
-    if [[ "$whl" != *"manylinux"* ]]; then
-        auditwheel repair $whl -w dist
-        rm $whl
-    fi
+    # Test that each wheel is installable.
+    # Test without virtualenv because it's not present on manylinux containers.
+    for release in dist/*; do
+        testinstall $PYTHON $release "without-virtualenv"
+        mv $release validdist/
+    done
 done
+
+mv validdist/* dist
+rm -rf validdist
+ls dist

.evergreen/build-manylinux.sh

@@ -15,7 +15,7 @@ images=(quay.io/pypa/manylinux1_x86_64:2020-03-20-2fda31c \
 
 for image in "${images[@]}"; do
   docker pull $image
-  docker run --rm -v `pwd`:/pymongo $image /pymongo/.evergreen/build-manylinux-internal.sh
+  docker run --rm -v `pwd`:/src $image /src/.evergreen/build-manylinux-internal.sh
 done
 
 ls dist

.evergreen/build-windows.sh

@@ -1,18 +1,32 @@
 #!/bin/bash -ex
 
+# Get access to testinstall.
+. .evergreen/utils.sh
+
+# Create temp directory for validated files.
+rm -rf validdist
+mkdir -p validdist
+mv dist/* validdist || true
+
 for VERSION in 27 34 35 36 37 38; do
-    PYTHON=C:/Python/Python${VERSION}/python.exe
-    PYTHON32=C:/Python/32/Python${VERSION}/python.exe
-    if [[ $VERSION == "2.7" ]]; then
+    _pythons=(C:/Python/Python${VERSION}/python.exe \
+              C:/Python/32/Python${VERSION}/python.exe)
+    for PYTHON in "${_pythons[@]}"; do
+        if [[ $VERSION == "2.7" ]]; then
+            rm -rf build
+            $PYTHON setup.py bdist_egg
+        fi
         rm -rf build
-        $PYTHON setup.py bdist_egg
-        rm -rf build
-        $PYTHON32 setup.py bdist_egg
-    fi
-    rm -rf build
-    $PYTHON setup.py bdist_wheel
-    rm -rf build
-    $PYTHON32 setup.py bdist_wheel
+        $PYTHON setup.py bdist_wheel
+
+        # Test that each wheel is installable.
+        for release in dist/*; do
+            testinstall $PYTHON $release
+            mv $release validdist/
+        done
+    done
 done
 
+mv validdist/* dist
+rm -rf validdist
 ls dist

.evergreen/utils.sh

@@ -0,0 +1,55 @@
+#!/bin/bash -ex
+
+# Usage:
+# createvirtualenv /path/to/python /output/path/for/venv
+# * param1: Python binary to use for the virtualenv
+# * param2: Path to the virtualenv to create
+function createvirtualenv {
+    PYTHON=$1
+    VENVPATH=$2
+    if $PYTHON -m virtualenv --version; then
+        VIRTUALENV="$PYTHON -m virtualenv"
+    elif command -v virtualenv; then
+        VIRTUALENV="$(command -v virtualenv) -p $PYTHON"
+    else
+        echo "Cannot test without virtualenv"
+        exit 1
+    fi
+    $VIRTUALENV --system-site-packages --never-download $VENVPATH
+    if [ "Windows_NT" = "$OS" ]; then
+        . $VENVPATH/Scripts/activate
+    else
+        . $VENVPATH/bin/activate
+    fi
+}
+
+# Usage:
+# testinstall /path/to/python /path/to/.whl/or/.egg ["no-virtualenv"]
+# * param1: Python binary to test
+# * param2: Path to the wheel or egg file to install
+# * param3 (optional): If set to a non-empty string, don't create a virtualenv. Used in manylinux containers.
+function testinstall {
+    PYTHON=$1
+    RELEASE=$2
+    NO_VIRTUALENV=$3
+
+    if [ -z "$NO_VIRTUALENV" ]; then
+        createvirtualenv $PYTHON venvtestinstall
+        PYTHON=python
+    fi
+
+    if [[ $RELEASE == *.egg ]]; then
+        $PYTHON -m easy_install $RELEASE
+    else
+        $PYTHON -m pip install --upgrade $RELEASE
+    fi
+    cd tools
+    $PYTHON fail_if_no_c.py
+    $PYTHON -m pip uninstall -y pymongo
+    cd ..
+
+    if [ -z "$NO_VIRTUALENV" ]; then
+        deactivate
+        rm -rf venvtestinstall
+    fi
+}