address review pt1

Author: sleepyStick

pymongo/asynchronous/mongo_client.py

@@ -1042,21 +1042,18 @@ async def target() -> bool:
         self._opened = False
 
     def append_metadata(self, driver_info: DriverInfo) -> None:
+        """Appends the given metadata to existing driver metadata.
+
+        :param driver_info: a :class:`~pymongo.driver_info.DriverInfo`
+
+        .. versionadded:: 4.14
         """
-        Appends the given metadata to existing driver metadata.
-        """
-        metadata = self._options.pool_options.metadata
-        for k, v in driver_info._asdict().items():
-            if v is None:
-                continue
-            if k in metadata:
-                metadata[k] = f"{metadata[k]}|{v}"
-            elif k in metadata["driver"]:
-                metadata["driver"][k] = "{}|{}".format(
-                    metadata["driver"][k],
-                    v,
-                )
-        self._options.pool_options._set_metadata(metadata)
+
+        if not isinstance(driver_info, DriverInfo):
+            raise TypeError(
+                f"driver_info must be an instance of DriverInfo, not {type(driver_info)}"
+            )
+        self._options.pool_options._update_metadata(driver_info)
 
     def _should_pin_cursor(self, session: Optional[AsyncClientSession]) -> Optional[bool]:
         return self._options.load_balanced and not (session and session.in_transaction)

pymongo/pool_options.py

@@ -376,25 +376,31 @@ def __init__(
                 "async",
             )
         if driver:
-            if driver.name:
-                self.__metadata["driver"]["name"] = "{}|{}".format(
-                    self.__metadata["driver"]["name"],
-                    driver.name,
-                )
-            if driver.version:
-                self.__metadata["driver"]["version"] = "{}|{}".format(
-                    _METADATA["driver"]["version"],
-                    driver.version,
-                )
-            if driver.platform:
-                self.__metadata["platform"] = "{}|{}".format(_METADATA["platform"], driver.platform)
+            self._update_metadata(driver)
 
         env = _metadata_env()
         if env:
             self.__metadata["env"] = env
 
         _truncate_metadata(self.__metadata)
 
+    def _update_metadata(self, driver: DriverInfo):
+        """Updates the client's metadata"""
+        if driver.name:
+            self.__metadata["driver"]["name"] = "{}|{}".format(
+                self.__metadata["driver"]["name"],
+                driver.name,
+            )
+        if driver.version:
+            self.__metadata["driver"]["version"] = "{}|{}".format(
+                self.__metadata["driver"]["version"],
+                driver.version,
+            )
+        if driver.platform:
+            self.__metadata["platform"] = "{}|{}".format(
+                self.__metadata["platform"], driver.platform
+            )
+
     @property
     def _credentials(self) -> Optional[MongoCredential]:
         """A :class:`~pymongo.auth.MongoCredentials` instance or None."""
@@ -522,6 +528,3 @@ def server_api(self) -> Optional[ServerApi]:
     def load_balanced(self) -> Optional[bool]:
         """True if this Pool is configured in load balanced mode."""
         return self.__load_balanced
-
-    def _set_metadata(self, new_data: dict[str, Any]) -> None:
-        self.__metadata = new_data

pymongo/synchronous/mongo_client.py

@@ -1042,21 +1042,18 @@ def target() -> bool:
         self._opened = False
 
     def append_metadata(self, driver_info: DriverInfo) -> None:
+        """Appends the given metadata to existing driver metadata.
+
+        :param driver_info: a :class:`~pymongo.driver_info.DriverInfo`
+
+        .. versionadded:: 4.14
         """
-        Appends the given metadata to existing driver metadata.
-        """
-        metadata = self._options.pool_options.metadata
-        for k, v in driver_info._asdict().items():
-            if v is None:
-                continue
-            if k in metadata:
-                metadata[k] = f"{metadata[k]}|{v}"
-            elif k in metadata["driver"]:
-                metadata["driver"][k] = "{}|{}".format(
-                    metadata["driver"][k],
-                    v,
-                )
-        self._options.pool_options._set_metadata(metadata)
+
+        if not isinstance(driver_info, DriverInfo):
+            raise TypeError(
+                f"driver_info must be an instance of DriverInfo, not {type(driver_info)}"
+            )
+        self._options.pool_options._update_metadata(driver_info)
 
     def _should_pin_cursor(self, session: Optional[ClientSession]) -> Optional[bool]:
         return self._options.load_balanced and not (session and session.in_transaction)