Refactor

Author: aclark4life

test/test_uri_parser.py

@@ -37,6 +37,26 @@
 )
 
 
+def run_initial_dns_seedlist_discovery_prose_tests(self, test_cases):
+    for case in test_cases:
+        with patch("dns.resolver.resolve") as mock_resolver:
+
+            def mock_resolve(query, record_type, *args, **kwargs):
+                mock_srv = MagicMock()
+                mock_srv.target.to_text.return_value = case["mock_target"]
+                return [mock_srv]
+
+            mock_resolver.side_effect = mock_resolve
+            domain = case["query"].split("._tcp.")[1]
+            connection_string = f"mongodb+srv://{domain}"
+            try:
+                parse_uri(connection_string)
+            except ConfigurationError as e:
+                self.assertIn(case["expected_error"], str(e))
+            else:
+                self.fail(f"ConfigurationError was not raised for query: {case['query']}")
+
+
 class TestURI(unittest.TestCase):
     def test_validate_userinfo(self):
         self.assertRaises(InvalidURI, parse_userinfo, "foo@")
@@ -580,23 +600,7 @@ def test_2_throw_when_return_address_does_not_end_with_srv_domain(self):
                 "expected_error": "Invalid SRV host",
             },
         ]
-        for case in test_cases:
-            with patch("dns.resolver.resolve") as mock_resolver:
-
-                def mock_resolve(query, record_type, *args, **kwargs):
-                    mock_srv = MagicMock()
-                    mock_srv.target.to_text.return_value = case["mock_target"]
-                    return [mock_srv]
-
-                mock_resolver.side_effect = mock_resolve
-                domain = case["query"].split("._tcp.")[1]
-                connection_string = f"mongodb+srv://{domain}"
-                try:
-                    parse_uri(connection_string)
-                except ConfigurationError as e:
-                    self.assertIn(case["expected_error"], str(e))
-                else:
-                    self.fail(f"ConfigurationError was not raised for query: {case['query']}")
+        run_initial_dns_seedlist_discovery_prose_tests(self, test_cases)
 
     def test_3_throw_when_return_address_is_identical_to_srv_hostname(self):
         test_cases = [
@@ -611,23 +615,7 @@ def test_3_throw_when_return_address_is_identical_to_srv_hostname(self):
                 "expected_error": "Invalid SRV host",
             },
         ]
-        for case in test_cases:
-            with patch("dns.resolver.resolve") as mock_resolver:
-
-                def mock_resolve(query, record_type, *args, **kwargs):
-                    mock_srv = MagicMock()
-                    mock_srv.target.to_text.return_value = case["mock_target"]
-                    return [mock_srv]
-
-                mock_resolver.side_effect = mock_resolve
-                domain = case["query"].split("._tcp.")[1]
-                connection_string = f"mongodb+srv://{domain}"
-                try:
-                    parse_uri(connection_string)
-                except ConfigurationError as e:
-                    self.assertIn(case["expected_error"], str(e))
-                else:
-                    self.fail(f"ConfigurationError was not raised for query: {case['query']}")
+        run_initial_dns_seedlist_discovery_prose_tests(self, test_cases)
 
     def test_4_throw_when_return_address_does_not_contain_dot_separating_shared_part_of_domain(
         self
@@ -649,23 +637,7 @@ def test_4_throw_when_return_address_does_not_contain_dot_separating_shared_part
                 "expected_error": "Invalid SRV host",
             },
         ]
-        for case in test_cases:
-            with patch("dns.resolver.resolve") as mock_resolver:
-
-                def mock_resolve(query, record_type, *args, **kwargs):
-                    mock_srv = MagicMock()
-                    mock_srv.target.to_text.return_value = case["mock_target"]
-                    return [mock_srv]
-
-                mock_resolver.side_effect = mock_resolve
-                domain = case["query"].split("._tcp.")[1]
-                connection_string = f"mongodb+srv://{domain}"
-                try:
-                    parse_uri(connection_string)
-                except ConfigurationError as e:
-                    self.assertIn(case["expected_error"], str(e))
-                else:
-                    self.fail(f"ConfigurationError was not raised for query: {case['query']}")
+        run_initial_dns_seedlist_discovery_prose_tests(self, test_cases)
 
 
 if __name__ == "__main__":