PYTHON-3917 Fix handling of warnings in connection string tests (#1357)

Author: blink1073

test/test_uri_spec.py

@@ -73,8 +73,8 @@ def setUp(self):
         clear_warning_registry()
 
 
-def get_error_message_template(expected, artefact):
-    return "{} {} for test '{}'".format("Expected" if expected else "Unexpected", artefact, "%s")
+def get_error_message_template(expected, artifact):
+    return "{} {} for test '{}'".format("Expected" if expected else "Unexpected", artifact, "%s")
 
 
 def run_scenario_in_dir(target_workdir):
@@ -99,25 +99,27 @@ def run_scenario(self):
             self.skipTest("This test needs dnspython package.")
         valid = True
         warning = False
+        expected_warning = test.get("warning", False)
+        expected_valid = test.get("valid", True)
 
         with warnings.catch_warnings(record=True) as ctx:
-            warnings.simplefilter("always")
+            warnings.simplefilter("ignore", category=ResourceWarning)
             try:
                 options = parse_uri(test["uri"], warn=True)
             except Exception:
                 valid = False
             else:
                 warning = len(ctx) > 0
+                if expected_valid and warning and not expected_warning:
+                    raise ValueError("Got unexpected warning(s): ", [str(i) for i in ctx])
 
-        expected_valid = test.get("valid", True)
         self.assertEqual(
             valid,
             expected_valid,
             get_error_message_template(not expected_valid, "error") % test["description"],
         )
 
         if expected_valid:
-            expected_warning = test.get("warning", False)
             self.assertEqual(
                 warning,
                 expected_warning,