PYTHON-5514 Specific assertions for "is" and "is not None" (#2502)

Author: sleepyStick

test/asynchronous/test_collection.py

@@ -1319,7 +1319,7 @@ async def test_error_code(self):
             self.assertIn(exc.code, (9, 10147, 16840, 17009))
             # Just check that we set the error document. Fields
             # vary by MongoDB version.
-            self.assertTrue(exc.details is not None)
+            self.assertIsNotNone(exc.details)
         else:
             self.fail("OperationFailure was not raised")
 

test/asynchronous/test_session.py

@@ -378,9 +378,9 @@ async def test_cursor_clone(self):
 
         async with self.client.start_session() as s:
             cursor = coll.find(session=s)
-            self.assertTrue(cursor.session is s)
+            self.assertIs(cursor.session, s)
             clone = cursor.clone()
-            self.assertTrue(clone.session is s)
+            self.assertIs(clone.session, s)
 
         # No explicit session.
         cursor = coll.find(batch_size=2)
@@ -392,7 +392,7 @@ async def test_cursor_clone(self):
         await anext(clone)
         self.assertIsNone(clone.session)
         self.assertIsNotNone(clone._session)
-        self.assertFalse(cursor._session is clone._session)
+        self.assertIsNot(cursor._session, clone._session)
         await cursor.close()
         await clone.close()
 

test/test_collection.py

@@ -1305,7 +1305,7 @@ def test_error_code(self):
             self.assertIn(exc.code, (9, 10147, 16840, 17009))
             # Just check that we set the error document. Fields
             # vary by MongoDB version.
-            self.assertTrue(exc.details is not None)
+            self.assertIsNotNone(exc.details)
         else:
             self.fail("OperationFailure was not raised")
 

test/test_session.py

@@ -378,9 +378,9 @@ def test_cursor_clone(self):
 
         with self.client.start_session() as s:
             cursor = coll.find(session=s)
-            self.assertTrue(cursor.session is s)
+            self.assertIs(cursor.session, s)
             clone = cursor.clone()
-            self.assertTrue(clone.session is s)
+            self.assertIs(clone.session, s)
 
         # No explicit session.
         cursor = coll.find(batch_size=2)
@@ -392,7 +392,7 @@ def test_cursor_clone(self):
         next(clone)
         self.assertIsNone(clone.session)
         self.assertIsNotNone(clone._session)
-        self.assertFalse(cursor._session is clone._session)
+        self.assertIsNot(cursor._session, clone._session)
         cursor.close()
         clone.close()