PHPLIB-1492: Support sort option for updateOne and replaceOne (#1605)

jmikola · web-flow · commit 85447eb583d5 · 2025-02-25T15:50:51.000-05:00
Addresses both single-statement updates and bulk writes.

* Require PHPC 1.21-dev for CI builds
diff --git a/.evergreen/config/generated/build/build-extension.yml b/.evergreen/config/generated/build/build-extension.yml
diff --git a/.evergreen/config/templates/build/build-extension.yml b/.evergreen/config/templates/build/build-extension.yml
@@ -5,6 +5,9 @@
         vars:
           PHP_VERSION: "%phpVersion%"
       - func: "compile extension"
+        # TODO: remove once 1.21.0 is released
+        vars:
+          EXTENSION_BRANCH: "v1.x"
       - func: "upload extension"
   - name: "build-php-%phpVersion%-lowest"
     tags: ["build", "php%phpVersion%", "lowest", "pr", "tag"]
@@ -14,7 +17,9 @@
           PHP_VERSION: "%phpVersion%"
       - func: "compile extension"
         vars:
-          EXTENSION_VERSION: "1.20.0"
+          # TODO: change to "EXTENSION_VERSION: 1.21.0" once 1.21.0 is released
+          # EXTENSION_VERSION: "1.21.0"
+          EXTENSION_BRANCH: "v1.x"
       - func: "upload extension"
   - name: "build-php-%phpVersion%-next-stable"
     tags: ["build", "php%phpVersion%", "next-stable", "pr", "tag"]
@@ -24,7 +29,9 @@
           PHP_VERSION: "%phpVersion%"
       - func: "compile extension"
         vars:
-          EXTENSION_BRANCH: "v1.20"
+          # TODO: change to "v1.21" once 1.21.0 is released
+          # EXTENSION_BRANCH: "v1.21"
+          EXTENSION_BRANCH: "v1.x"
       - func: "upload extension"
   - name: "build-php-%phpVersion%-next-minor"
     tags: ["build", "php%phpVersion%", "next-minor"]
diff --git a/.github/workflows/coding-standards.yml b/.github/workflows/coding-standards.yml
@@ -13,7 +13,9 @@ on:
 
 env:
   PHP_VERSION: "8.2"
-  DRIVER_VERSION: "stable"
+  # TODO: change to "stable" once 1.21.0 is released
+  # DRIVER_VERSION: "stable"
+  DRIVER_VERSION: "mongodb/mongo-php-driver@v1.x"
 
 jobs:
   phpcs:
diff --git a/.github/workflows/generator.yml b/.github/workflows/generator.yml
@@ -13,9 +13,9 @@ on:
 
 env:
   PHP_VERSION: "8.2"
-  # TODO: change to "stable" once 1.20.0 is released
+  # TODO: change to "stable" once 1.21.0 is released
   # DRIVER_VERSION: "stable"
-  DRIVER_VERSION: "mongodb/mongo-php-driver@v1.20"
+  DRIVER_VERSION: "mongodb/mongo-php-driver@v1.x"
 
 jobs:
   psalm:
diff --git a/.github/workflows/static-analysis.yml b/.github/workflows/static-analysis.yml
@@ -19,7 +19,9 @@ on:
 
 env:
   PHP_VERSION: "8.2"
-  DRIVER_VERSION: "stable"
+  # TODO: change to "stable" once 1.21.0 is released
+  # DRIVER_VERSION: "stable"
+  DRIVER_VERSION: "mongodb/mongo-php-driver@v1.x"
 
 jobs:
   psalm:
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -12,7 +12,9 @@ on:
       - "feature/*"
 
 env:
-  DRIVER_VERSION: "stable"
+  # TODO: change to "stable" once 1.21.0 is released
+  # DRIVER_VERSION: "stable"
+  DRIVER_VERSION: "mongodb/mongo-php-driver@v1.x"
 
 jobs:
   phpunit:
diff --git a/composer.json b/composer.json
@@ -13,7 +13,7 @@
         "php": "^8.1",
         "ext-hash": "*",
         "ext-json": "*",
-        "ext-mongodb": "^1.20.0",
+        "ext-mongodb": "^1.21.0",
         "composer-runtime-api": "^2.0",
         "psr/log": "^1.1.4|^2|^3",
         "symfony/polyfill-php80": "^1.27",
diff --git a/src/Operation/BulkWrite.php b/src/Operation/BulkWrite.php
@@ -91,6 +91,14 @@ class BulkWrite implements Executable
      *  * upsert (boolean): When true, a new document is created if no document
      *    matches the query. The default is false.
      *
+     * Supported options for replaceOne and updateOne operations:
+     *
+     *  * sort (document): Determines which document the operation modifies if
+     *    the query selects multiple documents.
+     *
+     *    This is not supported for server versions < 8.0 and will result in an
+     *    exception at execution time if used.
+     *
      * Supported options for updateMany and updateOne operations:
      *
      *  * arrayFilters (document array): A set of filters specifying to which
@@ -372,6 +380,10 @@ private function validateOperations(array $operations, ?DocumentCodec $codec, En
                         throw InvalidArgumentException::expectedDocumentType(sprintf('$operations[%d]["%s"][2]["collation"]', $i, $type), $args[2]['collation']);
                     }
 
+                    if (isset($args[2]['sort']) && ! is_document($args[2]['sort'])) {
+                        throw InvalidArgumentException::expectedDocumentType(sprintf('$operations[%d]["%s"][2]["sort"]', $i, $type), $args[2]['sort']);
+                    }
+
                     if (! is_bool($args[2]['upsert'])) {
                         throw InvalidArgumentException::invalidType(sprintf('$operations[%d]["%s"][2]["upsert"]', $i, $type), $args[2]['upsert'], 'boolean');
                     }
@@ -413,6 +425,14 @@ private function validateOperations(array $operations, ?DocumentCodec $codec, En
                         throw InvalidArgumentException::expectedDocumentType(sprintf('$operations[%d]["%s"][2]["collation"]', $i, $type), $args[2]['collation']);
                     }
 
+                    if (isset($args[2]['sort']) && ! is_document($args[2]['sort'])) {
+                        throw InvalidArgumentException::expectedDocumentType(sprintf('$operations[%d]["%s"][2]["sort"]', $i, $type), $args[2]['sort']);
+                    }
+
+                    if (isset($args[2]['sort']) && $args[2]['multi']) {
+                        throw new InvalidArgumentException(sprintf('"sort" option cannot be used with $operations[%d]["%s"]', $i, $type));
+                    }
+
                     if (! is_bool($args[2]['upsert'])) {
                         throw InvalidArgumentException::invalidType(sprintf('$operations[%d]["%s"][2]["upsert"]', $i, $type), $args[2]['upsert'], 'boolean');
                     }
diff --git a/src/Operation/ReplaceOne.php b/src/Operation/ReplaceOne.php
@@ -74,6 +74,12 @@ class ReplaceOne implements Executable
      *    Parameters can then be accessed as variables in an aggregate
      *    expression context (e.g. "$$var").
      *
+     *   * sort (document): Determines which document the operation modifies if
+     *     the query selects multiple documents.
+     *
+     *     This is not supported for server versions < 8.0 and will result in an
+     *     exception at execution time if used.
+     *
      *  * writeConcern (MongoDB\Driver\WriteConcern): Write concern.
      *
      * @param string       $databaseName   Database name
diff --git a/src/Operation/Update.php b/src/Operation/Update.php
@@ -149,6 +149,14 @@ public function __construct(private string $databaseName, private string $collec
             throw InvalidArgumentException::expectedDocumentType('"let" option', $options['let']);
         }
 
+        if (isset($options['sort']) && ! is_document($options['sort'])) {
+            throw InvalidArgumentException::expectedDocumentType('"sort" option', $options['sort']);
+        }
+
+        if (isset($options['sort']) && $options['multi']) {
+            throw new InvalidArgumentException('"sort" option cannot be used with multi-document updates');
+        }
+
         if (isset($options['bypassDocumentValidation']) && ! $options['bypassDocumentValidation']) {
             unset($options['bypassDocumentValidation']);
         }
@@ -270,8 +278,10 @@ private function createUpdateOptions(): array
             }
         }
 
-        if (isset($this->options['collation'])) {
-            $updateOptions['collation'] = (object) $this->options['collation'];
+        foreach (['collation', 'sort'] as $option) {
+            if (isset($this->options[$option])) {
+                $updateOptions[$option] = (object) $this->options[$option];
+            }
         }
 
         return $updateOptions;
diff --git a/src/Operation/UpdateOne.php b/src/Operation/UpdateOne.php
@@ -72,6 +72,12 @@ class UpdateOne implements Executable, Explainable
      *    Parameters can then be accessed as variables in an aggregate
      *    expression context (e.g. "$$var").
      *
+     *  * sort (document): Determines which document the operation modifies if
+     *    the query selects multiple documents.
+     *
+     *    This is not supported for server versions < 8.0 and will result in an
+     *    exception at execution time if used.
+     *
      *  * writeConcern (MongoDB\Driver\WriteConcern): Write concern.
      *
      * @param string       $databaseName   Database name
diff --git a/tests/Operation/BulkWriteTest.php b/tests/Operation/BulkWriteTest.php
@@ -217,6 +217,16 @@ public function testReplaceOneCollationOptionTypeCheck($collation): void
         ]);
     }
 
+    #[DataProvider('provideInvalidDocumentValues')]
+    public function testReplaceOneSortOptionTypeCheck($sort): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessageMatches('/Expected \$operations\[0\]\["replaceOne"\]\[2\]\["sort"\] to have type "document" \(array or object\) but found ".+"/');
+        new BulkWrite($this->getDatabaseName(), $this->getCollectionName(), [
+            [BulkWrite::REPLACE_ONE => [['x' => 1], ['y' => 1], ['sort' => $sort]]],
+        ]);
+    }
+
     #[DataProvider('provideInvalidBooleanValues')]
     public function testReplaceOneUpsertOptionTypeCheck($upsert): void
     {
@@ -322,6 +332,15 @@ public function testUpdateManyCollationOptionTypeCheck($collation): void
         ]);
     }
 
+    public function testUpdateManyProhibitsSortOption(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('"sort" option cannot be used with $operations[0]["updateMany"]');
+        new BulkWrite($this->getDatabaseName(), $this->getCollectionName(), [
+            [BulkWrite::UPDATE_MANY => [['x' => 1], ['$set' => ['y' => 1]], ['sort' => ['z' => 1]]]],
+        ]);
+    }
+
     #[DataProvider('provideInvalidBooleanValues')]
     public function testUpdateManyUpsertOptionTypeCheck($upsert): void
     {
@@ -410,6 +429,16 @@ public function testUpdateOneCollationOptionTypeCheck($collation): void
         ]);
     }
 
+    #[DataProvider('provideInvalidDocumentValues')]
+    public function testUpdateOneSortOptionTypeCheck($sort): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessageMatches('/Expected \$operations\[0\]\["updateOne"\]\[2\]\["sort"\] to have type "document" \(array or object\) but found ".+"/');
+        new BulkWrite($this->getDatabaseName(), $this->getCollectionName(), [
+            [BulkWrite::UPDATE_ONE => [['x' => 1], ['$set' => ['y' => 1]], ['sort' => $sort]]],
+        ]);
+    }
+
     #[DataProvider('provideInvalidBooleanValues')]
     public function testUpdateOneUpsertOptionTypeCheck($upsert): void
     {
diff --git a/tests/Operation/UpdateTest.php b/tests/Operation/UpdateTest.php
@@ -40,6 +40,7 @@ public static function provideInvalidConstructorOptions()
             'collation' => self::getInvalidDocumentValues(),
             'hint' => self::getInvalidHintValues(),
             'multi' => self::getInvalidBooleanValues(),
+            'sort' => self::getInvalidDocumentValues(),
             'session' => self::getInvalidSessionValues(),
             'upsert' => self::getInvalidBooleanValues(),
             'writeConcern' => self::getInvalidWriteConcernValues(),
@@ -55,6 +56,13 @@ public function testConstructorMultiOptionProhibitsReplacementDocumentOrEmptyPip
         new Update($this->getDatabaseName(), $this->getCollectionName(), ['x' => 1], $update, ['multi' => true]);
     }
 
+    public function testConstructorMultiOptionProhibitsSortOption(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('"sort" option cannot be used with multi-document updates');
+        new Update($this->getDatabaseName(), $this->getCollectionName(), ['x' => 1], ['$set' => ['x' => 2]], ['multi' => true, 'sort' => ['x' => 1]]);
+    }
+
     public function testExplainableCommandDocument(): void
     {
         $options = [
diff --git a/tests/UnifiedSpecTests/UnifiedSpecTest.php b/tests/UnifiedSpecTests/UnifiedSpecTest.php
@@ -37,11 +37,6 @@ class UnifiedSpecTest extends FunctionalTestCase
         // mongoc_cluster_stream_for_server does not retry handshakes (CDRIVER-4532, PHPLIB-1033, PHPLIB-1042)
         'retryable-reads/retryable reads handshake failures' => 'Handshakes are not retried (CDRIVER-4532)',
         'retryable-writes/retryable writes handshake failures' => 'Handshakes are not retried (CDRIVER-4532)',
-        // sort option for update operations is not supported (PHPLIB-1492)
-        'crud/BulkWrite replaceOne-sort' => 'Sort for replace operations is not supported (PHPLIB-1492)',
-        'crud/BulkWrite updateOne-sort' => 'Sort for update operations is not supported (PHPLIB-1492)',
-        'crud/replaceOne-sort' => 'Sort for replace operations is not supported (PHPLIB-1492)',
-        'crud/updateOne-sort' => 'Sort for update operations is not supported (PHPLIB-1492)',
         'crud/bypassDocumentValidation' => 'bypassDocumentValidation is handled by libmongoc (PHPLIB-1576)',
     ];
 
diff --git a/tests/UnifiedSpecTests/Util.php b/tests/UnifiedSpecTests/Util.php

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,12 @@ class ReplaceOne implements Executable`
`74`	`74`	`* Parameters can then be accessed as variables in an aggregate`
`75`	`75`	`* expression context (e.g. "$$var").`
`76`	`76`	`*`
	`77`	`+ * * sort (document): Determines which document the operation modifies if`
	`78`	`+ * the query selects multiple documents.`
	`79`	`+ *`
	`80`	`+ * This is not supported for server versions < 8.0 and will result in an`
	`81`	`+ * exception at execution time if used.`
	`82`	`+ *`
`77`	`83`	`* * writeConcern (MongoDB\Driver\WriteConcern): Write concern.`
`78`	`84`	`*`
`79`	`85`	`* @param string $databaseName Database name`
Original file line number	Diff line number	Diff line change
`@@ -149,6 +149,14 @@ public function __construct(private string $databaseName, private string $collec`
`149`	`149`	`throw InvalidArgumentException::expectedDocumentType('"let" option', $options['let']);`
`150`	`150`	`}`
`151`	`151`
	`152`	`+ if (isset($options['sort']) && ! is_document($options['sort'])) {`
	`153`	`+ throw InvalidArgumentException::expectedDocumentType('"sort" option', $options['sort']);`
	`154`	`+ }`
	`155`	`+`
	`156`	`+ if (isset($options['sort']) && $options['multi']) {`
	`157`	`+ throw new InvalidArgumentException('"sort" option cannot be used with multi-document updates');`
	`158`	`+ }`
	`159`	`+`
`152`	`160`	`if (isset($options['bypassDocumentValidation']) && ! $options['bypassDocumentValidation']) {`
`153`	`161`	`unset($options['bypassDocumentValidation']);`
`154`	`162`	`}`
`@@ -270,8 +278,10 @@ private function createUpdateOptions(): array`
`270`	`278`	`}`
`271`	`279`	`}`
`272`	`280`
`273`		`- if (isset($this->options['collation'])) {`
`274`		`- $updateOptions['collation'] = (object) $this->options['collation'];`
	`281`	`+ foreach (['collation', 'sort'] as $option) {`
	`282`	`+ if (isset($this->options[$option])) {`
	`283`	`+ $updateOptions[$option] = (object) $this->options[$option];`
	`284`	`+ }`
`275`	`285`	`}`
`276`	`286`
`277`	`287`	`return $updateOptions;`