Switched options order for the convenient api

JAVA-3379

Author: rozza

driver-sync/src/main/com/mongodb/client/ClientSession.java

@@ -117,11 +117,11 @@ public interface ClientSession extends com.mongodb.session.ClientSession {
      * Execute the given function within a transaction.
      *
      * @param <T> the return type of the transaction body
-     * @param options         the transaction options
      * @param transactionBody the body of the transaction
+     * @param options         the transaction options
      * @return the return value of the transaction body
      * @mongodb.server.release 4.0
      * @since 3.11
      */
-    <T> T withTransaction(TransactionOptions options, TransactionBody<T> transactionBody);
+    <T> T withTransaction(TransactionBody<T> transactionBody, TransactionOptions options);
 }

driver-sync/src/main/com/mongodb/client/internal/ClientSessionImpl.java

@@ -179,11 +179,11 @@ private void unpinServerAddressOnError(final MongoException e) {
 
     @Override
     public <T> T withTransaction(final TransactionBody<T> transactionBody) {
-        return withTransaction(TransactionOptions.builder().build(), transactionBody);
+        return withTransaction(transactionBody, TransactionOptions.builder().build());
     }
 
     @Override
-    public <T> T withTransaction(final TransactionOptions options, final TransactionBody<T> transactionBody) {
+    public <T> T withTransaction(final TransactionBody<T> transactionBody, final TransactionOptions options) {
         notNull("transactionBody", transactionBody);
         long startTime = ClientSessionClock.INSTANCE.now();
         outer:

driver-sync/src/test/functional/com/mongodb/client/AbstractTransactionsTest.java

@@ -354,13 +354,13 @@ public Void execute() {
                                 }
                             });
                         } else {
-                            nonNullClientSession(clientSession).withTransaction(transactionOptions, new TransactionBody<Object>() {
+                            nonNullClientSession(clientSession).withTransaction(new TransactionBody<Object>() {
                                 @Override
                                 public Void execute() {
                                     executeOperations(arguments.getDocument("callback").getArray("operations"), true);
                                     return null;
                                 }
-                            });
+                            }, transactionOptions);
                         }
                     } else if (operationName.equals("targetedFailPoint")) {
                         assertTrue(failPoint == null);