TlsChannel support Buffer idiosyncrasies

Support flip(), mark(), reset() and position(n) for ByteBuffers

Cannot use compilerArgs --release=8

JAVA-3588

Author: rozza

driver-core/src/main/com/mongodb/internal/connection/tlschannel/ServerTlsChannel.java

@@ -35,6 +35,7 @@
 import javax.net.ssl.SSLSession;
 import javax.net.ssl.StandardConstants;
 import java.io.IOException;
+import java.nio.Buffer;
 import java.nio.ByteBuffer;
 import java.nio.channels.ByteChannel;
 import java.nio.channels.Channel;
@@ -399,7 +400,7 @@ private Optional<SNIServerName> getServerNameIndication() throws IOException, Eo
         }
         TlsChannelImpl.readFromChannel(underlying, inEncrypted.buffer); // IO block
       }
-      inEncrypted.buffer.flip();
+      ((Buffer) inEncrypted.buffer).flip();
       Map<Integer, SNIServerName> serverNames = TlsExplorer.explore(inEncrypted.buffer);
       inEncrypted.buffer.compact();
       SNIServerName hostName = serverNames.get(StandardConstants.SNI_HOST_NAME);
@@ -421,7 +422,7 @@ private int readRecordHeaderSize() throws IOException, EofException {
       }
       TlsChannelImpl.readFromChannel(underlying, inEncrypted.buffer); // IO block
     }
-    inEncrypted.buffer.flip();
+    ((Buffer) inEncrypted.buffer).flip();
     int recordHeaderSize = TlsExplorer.getRequiredSize(inEncrypted.buffer);
     inEncrypted.buffer.compact();
     return recordHeaderSize;

driver-core/src/main/com/mongodb/internal/connection/tlschannel/impl/BufferHolder.java

@@ -23,6 +23,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.nio.Buffer;
 import java.nio.ByteBuffer;
 import java.util.Optional;
 
@@ -111,7 +112,7 @@ public void enlarge() {
 
   private void resizeImpl(int newCapacity) {
     ByteBuffer newBuffer = allocator.allocate(newCapacity);
-    buffer.flip();
+    ((Buffer) buffer).flip();
     newBuffer.put(buffer);
     if (plainData) {
       zero();
@@ -128,9 +129,9 @@ private void resizeImpl(int newCapacity) {
    * <p>Typically used for security reasons, with buffers that contains now-unused plaintext.
    */
   public void zeroRemaining() {
-    buffer.mark();
+    ((Buffer) buffer).mark();
     buffer.put(zeros, 0, buffer.remaining());
-    buffer.reset();
+    ((Buffer) buffer).reset();
   }
 
   /**
@@ -139,10 +140,10 @@ public void zeroRemaining() {
    * <p>Typically used for security reasons, with buffers that contains now-unused plaintext.
    */
   public void zero() {
-    buffer.mark();
-    buffer.position(0);
+    ((Buffer) buffer).mark();
+    ((Buffer) buffer).position(0);
     buffer.put(zeros, 0, buffer.remaining());
-    buffer.reset();
+    ((Buffer) buffer).reset();
   }
 
   public boolean nullOrEmpty() {

driver-core/src/main/com/mongodb/internal/connection/tlschannel/impl/ByteBufferUtil.java

@@ -19,6 +19,7 @@
 
 package com.mongodb.internal.connection.tlschannel.impl;
 
+import java.nio.Buffer;
 import java.nio.ByteBuffer;
 
 public class ByteBufferUtil {
@@ -43,8 +44,8 @@ public static void copy(ByteBuffer src, ByteBuffer dst, int length) {
       return;
     }
     ByteBuffer tmp = src.duplicate();
-    tmp.limit(src.position() + length);
+    ((Buffer) tmp).limit(src.position() + length);
     dst.put(tmp);
-    src.position(src.position() + length);
+    ((Buffer) src).position(src.position() + length);
   }
 }

driver-core/src/main/com/mongodb/internal/connection/tlschannel/impl/TlsChannelImpl.java

@@ -36,6 +36,7 @@
 import javax.net.ssl.SSLException;
 import javax.net.ssl.SSLSession;
 import java.io.IOException;
+import java.nio.Buffer;
 import java.nio.ByteBuffer;
 import java.nio.channels.ByteChannel;
 import java.nio.channels.ClosedChannelException;
@@ -210,7 +211,7 @@ public long read(ByteBufferSet dest) throws IOException, NeedsTaskException {
         throw new ClosedChannelException();
       }
       HandshakeStatus handshakeStatus = engine.getHandshakeStatus();
-      int bytesToReturn = inPlain.nullOrEmpty() ? 0 : inPlain.buffer.position();
+      int bytesToReturn = inPlain.nullOrEmpty() ? 0 :inPlain.buffer.position();
       while (true) {
         if (bytesToReturn > 0) {
           if (inPlain.nullOrEmpty()) {
@@ -263,7 +264,7 @@ private void handleTask() throws NeedsTaskException {
   }
 
   private int transferPendingPlain(ByteBufferSet dstBuffers) {
-    inPlain.buffer.flip(); // will read
+    ((Buffer) inPlain.buffer).flip(); // will read
     int bytes = dstBuffers.putRemaining(inPlain.buffer);
     inPlain.buffer.compact(); // will write
     boolean disposed = inPlain.release();
@@ -314,7 +315,7 @@ private UnwrapResult unwrapLoop(Optional<ByteBufferSet> dest, HandshakeStatus or
   }
 
   private SSLEngineResult callEngineUnwrap(ByteBufferSet dest) throws SSLException {
-    inEncrypted.buffer.flip();
+    ((Buffer) inEncrypted.buffer).flip();
     try {
       SSLEngineResult result =
           engine.unwrap(inEncrypted.buffer, dest.array, dest.offset, dest.length);
@@ -449,7 +450,7 @@ private void writeToChannel() throws IOException {
     if (outEncrypted.buffer.position() == 0) {
       return;
     }
-    outEncrypted.buffer.flip();
+    ((Buffer) outEncrypted.buffer).flip();
     try {
       try {
         writeToChannel(writeChannel, outEncrypted.buffer);

driver-core/src/main/com/mongodb/internal/connection/tlschannel/impl/TlsExplorer.java

@@ -23,6 +23,7 @@
 import javax.net.ssl.SNIServerName;
 import javax.net.ssl.SSLProtocolException;
 import javax.net.ssl.StandardConstants;
+import java.nio.Buffer;
 import java.nio.BufferUnderflowException;
 import java.nio.ByteBuffer;
 import java.util.HashMap;
@@ -51,7 +52,7 @@ private TlsExplorer() {}
    */
   public static int getRequiredSize(ByteBuffer source) {
     if (source.remaining() < RECORD_HEADER_SIZE) throw new BufferUnderflowException();
-    source.mark();
+    ((Buffer) source).mark();
     try {
       byte firstByte = source.get();
       source.get(); // second byte discarded
@@ -63,13 +64,13 @@ public static int getRequiredSize(ByteBuffer source) {
         return (((source.get() & 0xFF) << 8) | (source.get() & 0xFF)) + 5;
       }
     } finally {
-      source.reset();
+      ((Buffer) source).reset();
     }
   }
 
   public static Map<Integer, SNIServerName> explore(ByteBuffer source) throws SSLProtocolException {
     if (source.remaining() < RECORD_HEADER_SIZE) throw new BufferUnderflowException();
-    source.mark();
+    ((Buffer) source).mark();
     try {
       byte firstByte = source.get();
       ignore(source, 1); // ignore second byte
@@ -84,7 +85,7 @@ public static Map<Integer, SNIServerName> explore(ByteBuffer source) throws SSLP
         throw new SSLProtocolException("Not handshake record");
       }
     } finally {
-      source.reset();
+      ((Buffer) source).reset();
     }
   }
 
@@ -134,7 +135,7 @@ private static Map<Integer, SNIServerName> exploreHandshake(ByteBuffer input, in
     // records, but in practice this does not occur.
     if (handshakeLength > recordLength - 4) // 4: handshake header size
     throw new SSLProtocolException("Handshake message spans multiple records");
-    input.limit(handshakeLength + input.position());
+    ((Buffer) input).limit(handshakeLength + input.position());
     return exploreClientHello(input);
   }
 
@@ -257,7 +258,9 @@ private static void ignoreByteVector16(ByteBuffer input) {
   }
 
   private static void ignore(ByteBuffer input, int length) {
-    if (length != 0) input.position(input.position() + length);
+    if (length != 0) {
+      ((Buffer) input).position(input.position() + length);
+    }
   }
 
   // For some reason, SNIServerName is abstract