JAVA-2815: New abort and commit specification tests

Author: jyemin

driver-async/src/test/functional/com/mongodb/async/client/TransactionsTest.java

@@ -20,6 +20,7 @@
 import com.mongodb.ClientSessionOptions;
 import com.mongodb.MongoCommandException;
 import com.mongodb.MongoNamespace;
+import com.mongodb.MongoWriteConcernException;
 import com.mongodb.ReadConcern;
 import com.mongodb.ReadConcernLevel;
 import com.mongodb.TransactionOptions;
@@ -265,11 +266,16 @@ public void execute() {
                         String expectedError = getErrorContainsField(expectedResult);
                         assertTrue(String.format("Expected '%s' but got '%s'", expectedError, e.getMessage()),
                                 e.getMessage().toLowerCase().contains(expectedError.toLowerCase()));
-                    } else if (hasErrorCodeNameField(expectedResult) || (e instanceof MongoCommandException)) {
+                    } else if (hasErrorCodeNameField(expectedResult) || (e instanceof MongoCommandException)
+                            || (e instanceof MongoWriteConcernException)) {
                         String expectedErrorCodeName = getErrorCodeNameField(expectedResult);
-                        MongoCommandException commandException = (MongoCommandException) e;
-                        assertEquals(expectedErrorCodeName,
-                                commandException.getResponse().getString("codeName", new BsonString("")).getValue());
+                        if (e instanceof MongoCommandException) {
+                            assertEquals(expectedErrorCodeName, ((MongoCommandException) e).getErrorCodeName());
+                        } else if (e instanceof MongoWriteConcernException) {
+                            assertEquals(expectedErrorCodeName, ((MongoWriteConcernException) e).getWriteConcernError().getCodeName());
+                        } else {
+                            throw e;
+                        }
                     } else {
                         throw e;
                     }

driver-core/src/test/resources/transactions/README.rst

@@ -144,7 +144,7 @@ Null Values
 ~~~~~~~~~~~
 
 Some command-started events in ``expectations`` include ``null`` values for
-fields such as ``txnNumber``, ``autocommit``, ``writeConcern``, and ``stmtId``.
+fields such as ``txnNumber``, ``autocommit``, and ``writeConcern``.
 Tests MUST assert that the actual command **omits** any field that has a
 ``null`` value in the expected command.
 

driver-core/src/test/resources/transactions/abort.json

@@ -537,6 +537,45 @@
           "data": []
         }
       }
+    },
+    {
+      "description": "abort does not apply writeConcern",
+      "operations": [
+        {
+          "name": "startTransaction",
+          "arguments": {
+            "session": "session0",
+            "options": {
+              "writeConcern": {
+                "w": 10
+              }
+            }
+          }
+        },
+        {
+          "name": "insertOne",
+          "arguments": {
+            "document": {
+              "_id": 1
+            },
+            "session": "session0"
+          },
+          "result": {
+            "insertedId": 1
+          }
+        },
+        {
+          "name": "abortTransaction",
+          "arguments": {
+            "session": "session0"
+          }
+        }
+      ],
+      "outcome": {
+        "collection": {
+          "data": []
+        }
+      }
     }
   ]
 }

driver-core/src/test/resources/transactions/commit.json

@@ -235,6 +235,52 @@
           ]
         }
       }
+    },
+    {
+      "description": "write concern error on commit",
+      "operations": [
+        {
+          "name": "startTransaction",
+          "arguments": {
+            "session": "session0",
+            "options": {
+              "writeConcern": {
+                "w": 10
+              }
+            }
+          }
+        },
+        {
+          "name": "insertOne",
+          "arguments": {
+            "document": {
+              "_id": 1
+            },
+            "session": "session0"
+          },
+          "result": {
+            "insertedId": 1
+          }
+        },
+        {
+          "name": "commitTransaction",
+          "arguments": {
+            "session": "session0"
+          },
+          "result": {
+            "errorCodeName": "CannotSatisfyWriteConcern"
+          }
+        }
+      ],
+      "outcome": {
+        "collection": {
+          "data": [
+            {
+              "_id": 1
+            }
+          ]
+        }
+      }
     }
   ]
 }

driver-sync/src/test/functional/com/mongodb/client/TransactionsTest.java

@@ -20,6 +20,7 @@
 import com.mongodb.ClientSessionOptions;
 import com.mongodb.MongoCommandException;
 import com.mongodb.MongoNamespace;
+import com.mongodb.MongoWriteConcernException;
 import com.mongodb.ReadConcern;
 import com.mongodb.ReadConcernLevel;
 import com.mongodb.TransactionOptions;
@@ -252,13 +253,17 @@ public void shouldPassAllOutcomes() {
                         String expectedError = getErrorContainsField(expectedResult);
                         assertTrue(String.format("Expected '%s' but got '%s'", expectedError, e.getMessage()),
                                 e.getMessage().toLowerCase().contains(expectedError.toLowerCase()));
-                    } else if (hasErrorCodeNameField(expectedResult) || (e instanceof MongoCommandException)) {
+                    } else if (hasErrorCodeNameField(expectedResult) || (e instanceof MongoCommandException)
+                            || (e instanceof MongoWriteConcernException)) {
                         String expectedErrorCodeName = getErrorCodeNameField(expectedResult);
-                        MongoCommandException commandException = (MongoCommandException) e;
-                        assertEquals(expectedErrorCodeName,
-                                commandException.getResponse().getString("codeName", new BsonString("")).getValue());
-                    }
-                    else {
+                        if (e instanceof MongoCommandException) {
+                            assertEquals(expectedErrorCodeName, ((MongoCommandException) e).getErrorCodeName());
+                        } else if (e instanceof MongoWriteConcernException) {
+                            assertEquals(expectedErrorCodeName, ((MongoWriteConcernException) e).getWriteConcernError().getCodeName());
+                        } else {
+                            throw e;
+                        }
+                    } else {
                         throw e;
                     }
                 }