In order to avoid equality testing issues when passed ServerAddress subclass instances, construct new ServerAddress instances in ClusterSettings.Builder.hosts method.

   JAVA-1814

Author: jyemin

driver-core/src/main/com/mongodb/connection/ClusterSettings.java

@@ -25,6 +25,7 @@
 import java.util.Collections;
 import java.util.LinkedHashSet;
 import java.util.List;
+import java.util.Set;
 import java.util.concurrent.TimeUnit;
 
 import static com.mongodb.assertions.Assertions.isTrueArgument;
@@ -94,7 +95,11 @@ public Builder hosts(final List<ServerAddress> hosts) {
             if (hosts.isEmpty()) {
                 throw new IllegalArgumentException("hosts list may not be empty");
             }
-            this.hosts = Collections.unmodifiableList(new ArrayList<ServerAddress>(new LinkedHashSet<ServerAddress>(hosts)));
+            Set<ServerAddress> hostsSet = new LinkedHashSet<ServerAddress>(hosts.size());
+            for (ServerAddress host : hosts) {
+                hostsSet.add(new ServerAddress(host.getHost(), host.getPort()));
+            }
+            this.hosts = Collections.unmodifiableList(new ArrayList<ServerAddress>(hostsSet));
             return this;
         }
 

driver-core/src/test/unit/com/mongodb/connection/ClusterSettingsSpecification.groovy

@@ -278,4 +278,19 @@ class ClusterSettingsSpecification extends Specification {
                        .maxWaitQueueSize(100)
                        .build().hashCode() != ClusterSettings.builder().hosts(hosts).build().hashCode()
     }
+
+    def 'should replace ServerAddress subclass instances with ServerAddress'() {
+        when:
+        def settings = ClusterSettings.builder().hosts([new ServerAddressSubclass('server1'),
+                                                        new ServerAddressSubclass('server2')]).build();
+
+        then:
+        settings.getHosts() == [new ServerAddress('server1'), new ServerAddress('server2')]
+    }
+
+    static class ServerAddressSubclass extends ServerAddress {
+        ServerAddressSubclass(final String host) {
+            super(host)
+        }
+    }
 }