Improve support for IPv6 addresses (#167)

Add support for IPv6 addresses defined without square brackets.
JAVA-2220

Author: rozza

driver-core/src/main/com/mongodb/ServerAddress.java

@@ -109,10 +109,11 @@ public ServerAddress(final String host, final int port) {
                 }
                 portToUse = Integer.parseInt(host.substring(portIdx + 2));
             }
-            hostToUse = host.substring(0, idx + 1);
+            hostToUse = host.substring(1, idx);
         } else {
             int idx = hostToUse.indexOf(":");
-            if (idx > 0) {
+            int lastIdx = hostToUse.lastIndexOf(":");
+            if (idx == lastIdx && idx > 0) {
                 if (port != defaultPort()) {
                     throw new IllegalArgumentException("can't specify port in construct and via host");
                 }
@@ -124,7 +125,6 @@ public ServerAddress(final String host, final int port) {
                 hostToUse = hostToUse.substring(0, idx).trim();
             }
         }
-
         this.host = hostToUse.toLowerCase();
         this.port = portToUse;
     }

driver-core/src/test/unit/com/mongodb/ServerAddressSpecification.groovy

@@ -24,8 +24,9 @@ class ServerAddressSpecification extends Specification {
     @Unroll
     def 'constructors should parse hostname and port correctly'() {
         expect:
-        address.getHost() == host;
-        address.getPort() == port;
+        address.getHost() == host
+        address.getPort() == port
+        address == new ServerAddress(host, port)
 
         where:
         address                                                 | host                           | port
@@ -37,10 +38,11 @@ class ServerAddressSpecification extends Specification {
         new ServerAddress('SOMEWHERE')                          | 'somewhere'                    | ServerAddress.defaultPort()
         new ServerAddress('somewhere:1000')                     | 'somewhere'                    | 1000
         new ServerAddress('somewhere', 1000)                    | 'somewhere'                    | 1000
-        new ServerAddress('[2010:836b:4179::836b:4179]')        | '[2010:836b:4179::836b:4179]'  | ServerAddress.defaultPort()
-        new ServerAddress('[2010:836B:4179::836B:4179]')        | '[2010:836b:4179::836b:4179]'  | ServerAddress.defaultPort()
-        new ServerAddress('[2010:836B:4179::836B:4179]:1000')   | '[2010:836b:4179::836b:4179]'  | 1000
-        new ServerAddress('[2010:836B:4179::836B:4179]', 1000)  | '[2010:836b:4179::836b:4179]'  | 1000
+        new ServerAddress('[2010:836B:4179::836B:4179]')        | '2010:836b:4179::836b:4179'    | ServerAddress.defaultPort()
+        new ServerAddress('[2010:836B:4179::836B:4179]:1000')   | '2010:836b:4179::836b:4179'    | 1000
+        new ServerAddress('[2010:836B:4179::836B:4179]', 1000)  | '2010:836b:4179::836b:4179'    | 1000
+        new ServerAddress('2010:836B:4179::836B:4179')          | '2010:836b:4179::836b:4179'    | ServerAddress.defaultPort()
+        new ServerAddress('2010:836B:4179::836B:4179', 1000)    | '2010:836b:4179::836b:4179'    | 1000
     }
 
     def 'ipv4 host with a port specified should throw when a port is also specified as an argument'() {
@@ -92,4 +94,4 @@ class ServerAddressSpecification extends Specification {
         then:
         thrown(MongoException);
     }
-}
+}

driver-core/src/test/unit/com/mongodb/connection/JMXConnectionPoolListenerSpecification.groovy

@@ -120,7 +120,7 @@ class JMXConnectionPoolListenerSpecification extends Specification {
         ObjectName objectName = new ObjectName(beanName)
 
         then:
-        objectName.toString() == "org.mongodb.driver:type=ConnectionPool,clusterId=${serverId.clusterId.value},host=\"[::1]\",port=27017"
+        objectName.toString() == "org.mongodb.driver:type=ConnectionPool,clusterId=${serverId.clusterId.value},host=\"::1\",port=27017"
     }
 
     def 'should include the description in the object name if set'() {