CSHARP-4202: Specify correct max supported wire version. (#816)

Author: DmitryLukyanov

src/MongoDB.Driver.Core/Core/Misc/WireVersion.cs

@@ -114,10 +114,10 @@ internal static class WireVersion
             new WireVersionInfo(wireVersion: 14, major: 5, minor: 1),
             new WireVersionInfo(wireVersion: 15, major: 5, minor: 2),
             new WireVersionInfo(wireVersion: 16, major: 5, minor: 3),
-            new WireVersionInfo(wireVersion: 17, major: 6, minor: 0),
+            new WireVersionInfo(wireVersion: 17, major: 6, minor: 0)
         };
 
-        private static Range<int> __supportedWireVersionRange = CreateSupportedWireVersionRange(minWireVersion: 6, maxWireVersion: 15);
+        private static Range<int> __supportedWireVersionRange = CreateSupportedWireVersionRange(minWireVersion: 6, maxWireVersion: 17);
 
         private static Range<int> CreateSupportedWireVersionRange(int minWireVersion, int maxWireVersion)
         {

tests/MongoDB.Driver.Core.TestHelpers/XunitExtensions/RequireServer.cs

@@ -140,6 +140,19 @@ public RequireServer Serverless(bool require = true)
             throw new SkipException("Test skipped because serverless is " + (require ? "required" : "not required") + ".");
         }
 
+        public RequireServer StableServer(bool stable = true)
+        {
+            var serverVersion = CoreTestConfiguration.ServerVersion;
+            var isStableServer = serverVersion.PreRelease == null;
+
+            if (isStableServer == stable)
+            {
+                return this;
+            }
+
+            throw new SkipException($"Test skipped because {(stable ? "GA" : "prerelease")} server version is expected, but found {serverVersion}.");
+        }
+
         public RequireServer Supports(Feature feature)
         {
             if (feature.IsSupported(_maxWireVersion))

tests/MongoDB.Driver.Core.Tests/Core/Clusters/ClusterDescriptionTests.cs

@@ -167,7 +167,7 @@ public void IsCompatibleWithDriver_should_return_expected_result(int[] wireRange
                 var endPoint = new DnsEndPoint("localhost", i);
                 var serverId = new ServerId(clusterId, endPoint);
                 var wireRange = wireRanges[i];
-                var wireVersionRange = wireRange == 0 ? new Range<int>(0, 0) : wireRange == 1 ? new Range<int>(6, 15) : null;
+                var wireVersionRange = wireRange == 0 ? new Range<int>(0, 0) : wireRange == 1 ? Cluster.SupportedWireVersionRange : null;
                 var server = new ServerDescription(serverId, endPoint, wireVersionRange: wireVersionRange, type: ServerType.Standalone);
                 subject = subject.WithServerDescription(server);
             }
@@ -204,7 +204,7 @@ public void IsCompatibleWithDriver_should_return_true_if_server_unknown(int[] wi
                 var endPoint = new DnsEndPoint("localhost", i);
                 var serverId = new ServerId(clusterId, endPoint);
                 var wireRange = wireRanges[i];
-                var wireVersionRange = wireRange == 0 ? new Range<int>(0, 0) : wireRange == 1 ? new Range<int>(6, 15) : null;
+                var wireVersionRange = wireRange == 0 ? new Range<int>(0, 0) : wireRange == 1 ? Cluster.SupportedWireVersionRange : null;
                 var server = new ServerDescription(serverId, endPoint, wireVersionRange: wireVersionRange, type: ServerType.Unknown);
                 subject = subject.WithServerDescription(server);
             }

tests/MongoDB.Driver.Core.Tests/Core/Clusters/ClusterTests.cs

@@ -60,7 +60,7 @@ public void SupportedWireVersionRange_should_return_expected_result()
         {
             var result = Cluster.SupportedWireVersionRange;
 
-            result.Should().Be(new Range<int>(6, 15));
+            result.Should().Be(new Range<int>(6, 17));
         }
 
         [Fact]
@@ -325,8 +325,8 @@ public void SelectServer_should_throw_if_the_matched_server_cannot_be_found_and_
         [Theory]
         [InlineData(0, 0, false)]
         [InlineData(0, 0, true)]
-        [InlineData(16, 17, false)]
-        [InlineData(16, 17, true)]
+        [InlineData(18, 19, false)]
+        [InlineData(18, 19, true)]
         public void SelectServer_should_throw_if_any_servers_are_incompatible(int min, int max, bool async)
         {
             var subject = CreateSubject();

tests/MongoDB.Driver.Core.Tests/Core/Misc/WireVersionTests.cs

@@ -16,12 +16,25 @@
 using System;
 using FluentAssertions;
 using MongoDB.Driver.Core.Misc;
+using MongoDB.Driver.Core.TestHelpers.XunitExtensions;
 using Xunit;
 
 namespace MongoDB.Driver.Core.Tests.Core.Misc
 {
     public class WireVersionTests
     {
+        [SkippableFact]
+        public void Server_maxWireVersion_should_be_in_supported_range()
+        {
+            RequireServer.Check().StableServer(stable: true);
+
+            var serverMaxWireVersion = CoreTestConfiguration.MaxWireVersion;
+
+            var isOverlaped = WireVersion.SupportedWireVersionRange.Overlaps(new Range<int>(serverMaxWireVersion, serverMaxWireVersion));
+
+            isOverlaped.Should().BeTrue();
+        }
+
         [Theory]
         [InlineData(14, "5.1")]
         [InlineData(1000, "Unknown (wire version 1000)")]
@@ -33,7 +46,7 @@ public void GetServerVersionForErrorMessage_should_return_expected_serverVersion
         [Fact]
         public void SupportedWireRange_should_be_correct()
         {
-            WireVersion.SupportedWireVersionRange.Should().Be(new Range<int>(6, 15));
+            WireVersion.SupportedWireVersionRange.Should().Be(new Range<int>(6, 17));
         }
 
         [Fact]
@@ -46,6 +59,7 @@ public void ToServerVersion_should_throw_if_wireVersion_less_than_0()
 
         [Theory]
         [InlineData(99, null, null)]
+        [InlineData(19, null, null)]
         [InlineData(18, null, null)]
         [InlineData(17, 6, 0)]
         [InlineData(16, 5, 3)]

tests/MongoDB.Driver.Core.Tests/Core/Servers/ServerDescriptionTests.cs

@@ -277,7 +277,8 @@ public void Equals_should_return_true_when_all_fields_are_equal()
         [InlineData(new[] { 13, 15 }, true)]
         [InlineData(new[] { 14, 15 }, true)]
         [InlineData(new[] { 15, 16 }, true)]
-        [InlineData(new[] { 16, 17 }, false)]
+        [InlineData(new[] { 16, 17 }, true)]
+        [InlineData(new[] { 18, 19 }, false)]
         public void IsCompatibleWithDriver_should_return_expected_result(int[] minMaxWireVersions, bool expectedResult)
         {
             var clusterId = new ClusterId(1);