CSHARP-551: Rename HaveIdIndex to HasIdIndex. Changed Flags to call SystemFlags to share code. Added test for non-zero UserFlags.

Author: rstam

Driver/Core/CommandResults/CollectionStatsResult.cs

@@ -36,7 +36,7 @@ public enum CollectionSystemFlags
         /// <summary>
         /// The collection has an _id index.
         /// </summary>
-        HaveIdIndex = 1
+        HasIdIndex = 1 // called HaveIdIndex in the server but renamed here to follow .NET naming conventions
     }
 
     /// <summary>
@@ -52,7 +52,7 @@ public enum CollectionUserFlags
         /// <summary>
         /// User power of 2 size.
         /// </summary>
-        UsePowerOf2Size = 1
+        UsePowerOf2Sizes = 1
     }
 
     /// <summary>
@@ -106,15 +106,7 @@ public int Flags
             get
             {
                 // flags was renamed to systemFlags in server version 2.2
-                BsonValue flags;
-                if (Response.TryGetValue("flags", out flags) || Response.TryGetValue("systemFlags", out flags))
-                {
-                    return flags.AsInt32;
-                }
-                else
-                {
-                    return 0;
-                }
+                return (int)SystemFlags;
             }
         }
 
@@ -205,7 +197,7 @@ public CollectionSystemFlags SystemFlags
         {
             get
             {
-                // systemFlags was called flags prior to server version 2.2
+                // systemFlags was first introduced in server version 2.2 (check "flags" also for compatibility with older servers)
                 BsonValue systemFlags;
                 if (Response.TryGetValue("systemFlags", out systemFlags) || Response.TryGetValue("flags", out systemFlags))
                 {

DriverUnitTests/Core/CommandResults/CollectionStatsResultTests.cs

@@ -71,7 +71,7 @@ public void Test()
             Assert.AreEqual(1, result.ObjectCount);
             Assert.IsTrue(result.PaddingFactor > 0.0);
             Assert.IsTrue(result.StorageSize > 0);
-            Assert.AreEqual(CollectionSystemFlags.HaveIdIndex, result.SystemFlags);
+            Assert.AreEqual(CollectionSystemFlags.HasIdIndex, result.SystemFlags);
             Assert.IsTrue(result.TotalIndexSize > 0);
             Assert.AreEqual(CollectionUserFlags.None, result.UserFlags);
         }

DriverUnitTests/Core/MongoCollectionTests.cs

@@ -1341,7 +1341,27 @@ public void TestSortAndLimit()
         [Test]
         public void TestGetStats()
         {
-            var dataSize = _collection.GetStats();
+            var stats = _collection.GetStats();
+        }
+
+        [Test]
+        public void TestGetStatsUsePowerOf2Sizes()
+        {
+            if (_server.BuildInfo.Version >= new Version(2, 2))
+            {
+                _collection.Drop();
+                _database.CreateCollection(_collection.Name); // collMod command only works if collection exists
+
+                var command = new CommandDocument
+                {
+                    { "collMod", _collection.Name },
+                    { "usePowerOf2Sizes", true }
+                };
+                _database.RunCommand(command);
+
+                var stats = _collection.GetStats();
+                Assert.IsTrue((stats.UserFlags & CollectionUserFlags.UsePowerOf2Sizes) != 0);
+            }
         }
 
         [Test]