Added constructor to avoid api compat issue

Author: papafe

src/MongoDB.Driver/RenderArgs.cs

@@ -50,16 +50,14 @@ public record struct RenderArgs<TDocument>
         /// <param name="renderForFind">Value that specifies whether rendering a find operation.</param>
         /// <param name="renderForElemMatch">Value that specifies whether rendering an $elemMatch.</param>
         /// <param name="translationOptions">The translation options.</param>
-        /// <param name="serializationDomain">//TODO</param>
         public RenderArgs(
             IBsonSerializer<TDocument> documentSerializer,
             IBsonSerializerRegistry serializerRegistry,
             PathRenderArgs pathRenderArgs = default,
             bool renderDollarForm = default,
             bool renderForFind = false,
             bool renderForElemMatch = false,
-            ExpressionTranslationOptions translationOptions = null,
-            IBsonSerializationDomain serializationDomain = null)
+            ExpressionTranslationOptions translationOptions = null)
         {
             DocumentSerializer = documentSerializer;
             PathRenderArgs = pathRenderArgs;
@@ -68,7 +66,35 @@ public RenderArgs(
             _renderForFind = renderForFind;
             _renderForElemMatch = renderForElemMatch;
             _translationOptions = translationOptions; // can be null
-            _serializationDomain = serializationDomain ?? BsonSerializer.DefaultSerializationDomain;  //TODO Should we do it like this?
+        }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="RenderArgs{TDocument}"/> record.
+        /// </summary>
+        /// <param name="documentSerializer">The document serializer.</param>
+        /// <param name="pathRenderArgs">The path render arguments.</param>
+        /// <param name="renderDollarForm">Value that specifies whether full dollar for should be rendered.</param>
+        /// <param name="renderForFind">Value that specifies whether rendering a find operation.</param>
+        /// <param name="renderForElemMatch">Value that specifies whether rendering an $elemMatch.</param>
+        /// <param name="translationOptions">The translation options.</param>
+        /// <param name="serializationDomain">//TODO</param>
+        public RenderArgs(
+            IBsonSerializer<TDocument> documentSerializer,
+            IBsonSerializationDomain serializationDomain,
+            PathRenderArgs pathRenderArgs = default,
+            bool renderDollarForm = default,
+            bool renderForFind = false,
+            bool renderForElemMatch = false,
+            ExpressionTranslationOptions translationOptions = null)
+        {
+            DocumentSerializer = documentSerializer;
+            PathRenderArgs = pathRenderArgs;
+            RenderDollarForm = renderDollarForm;
+            _serializationDomain = serializationDomain ?? BsonSerializer.DefaultSerializationDomain;
+            _renderForFind = renderForFind;
+            _renderForElemMatch = renderForElemMatch;
+            _translationOptions = translationOptions; // can be null
+            SerializerRegistry = _serializationDomain.SerializerRegistry;
         }
 
         /// <summary>
@@ -142,6 +168,6 @@ public readonly IBsonSerializer<T> GetSerializer<T>() =>
         /// A new RenderArgs{TNewDocument} instance.
         /// </returns>
         public readonly RenderArgs<TNewDocument> WithNewDocumentType<TNewDocument>(IBsonSerializer<TNewDocument> serializer) =>
-            new(serializer, _serializerRegistry, _pathRenderArgs, _renderDollarForm, _renderForFind, _renderForElemMatch, _translationOptions, _serializationDomain);
+            new(serializer, _serializationDomain, _pathRenderArgs, _renderDollarForm, _renderForFind, _renderForElemMatch, _translationOptions);
     }
 }

tests/MongoDB.Driver.Tests/FilterDefinitionBuilderNullableEnumComparedToNullableEnumWithStringRepresentationTests.cs

@@ -25,8 +25,7 @@ public class FilterDefinitionBuilderNullableEnumComparedToNullableEnumWithString
     {
         private static RenderArgs<C> __args = new(
             BsonSerializer.DefaultSerializationDomain.SerializerRegistry.GetSerializer<C>(),
-            BsonSerializer.DefaultSerializationDomain.SerializerRegistry,
-            serializationDomain: BsonSerializer.DefaultSerializationDomain);
+            BsonSerializer.DefaultSerializationDomain);
         private static FilterDefinitionBuilder<C> __subject = Builders<C>.Filter;
 
         public enum E { A, B }

tests/MongoDB.Driver.Tests/FilterDefinitionBuilderTests.cs

@@ -1045,7 +1045,7 @@ private void Assert<TDocument>(FilterDefinition<TDocument> filter, string expect
         private void Assert<TDocument>(FilterDefinition<TDocument> filter, BsonDocument expected)
         {
             var documentSerializer = BsonSerializer.DefaultSerializationDomain.SerializerRegistry.GetSerializer<TDocument>();
-            var renderedFilter = filter.Render(new(documentSerializer, BsonSerializer.SerializerRegistry, serializationDomain: BsonSerializer.DefaultSerializationDomain));
+            var renderedFilter = filter.Render(new(documentSerializer,  BsonSerializer.DefaultSerializationDomain));
 
             renderedFilter.Should().Be(expected);
         }