Some comments

Author: papafe

src/MongoDB.Bson/BsonExtensionMethods.cs

@@ -25,6 +25,8 @@ namespace MongoDB.Bson
     /// </summary>
     public static class BsonExtensionMethods
     {
+        //DOMAIN-API We should remove this and use the version with the domain.
+        //QUESTION: Do we want to do something now about this...? It's used also internally, but in a huge number of places.
         /// <summary>
         /// Serializes an object to a BSON byte array.
         /// </summary>
@@ -49,6 +51,21 @@ public static byte[] ToBson<TNominalType>(
             return ToBson(obj, typeof(TNominalType), writerSettings, serializer, configurator, args, estimatedBsonSize);
         }
 
+        internal static byte[] ToBson<TNominalType>(
+            this TNominalType obj,
+            IBsonSerializationDomain serializationDomain,
+            IBsonSerializer<TNominalType> serializer = null,
+            BsonBinaryWriterSettings writerSettings = null,
+            Action<BsonSerializationContext.Builder> configurator = null,
+            BsonSerializationArgs args = default(BsonSerializationArgs),
+            int estimatedBsonSize = 0)
+        {
+            args.SetOrValidateNominalType(typeof(TNominalType), "<TNominalType>");
+
+            return ToBson(obj, typeof(TNominalType), serializationDomain, writerSettings, serializer, configurator, args, estimatedBsonSize);
+        }
+
+        //DOMAIN-API We should remove this and use the version with the domain.
         /// <summary>
         /// Serializes an object to a BSON byte array.
         /// </summary>

src/MongoDB.Bson/Properties/AssemblyInfo.cs

@@ -30,3 +30,5 @@
 [assembly: InternalsVisibleTo("MongoDB.Analyzer.MQLGenerator, PublicKey=002400000480000094000000060200000024000052534131000400000100010035287f0d3883c0a075c88e0cda3ce93b621003ecbd5e920d4a8c7238564f4d2f4f68116aca28c9b21341dc3a877679c14556192b2b2f5fe2c11d624e0894d308ff7b94bf6fd72aef1b41017ffe2572e99019d1c61963e68cd0ed67734a42cb333b808e3867cbe631937214e32e409fb1fa62fdb69d494c2530e64a40e417d6ee")]
 [assembly: InternalsVisibleTo("MongoDB.Driver, PublicKey=002400000480000094000000060200000024000052534131000400000100010035287f0d3883c0a075c88e0cda3ce93b621003ecbd5e920d4a8c7238564f4d2f4f68116aca28c9b21341dc3a877679c14556192b2b2f5fe2c11d624e0894d308ff7b94bf6fd72aef1b41017ffe2572e99019d1c61963e68cd0ed67734a42cb333b808e3867cbe631937214e32e409fb1fa62fdb69d494c2530e64a40e417d6ee")]
 [assembly: InternalsVisibleTo("MongoDB.Driver.Tests, PublicKey=002400000480000094000000060200000024000052534131000400000100010035287f0d3883c0a075c88e0cda3ce93b621003ecbd5e920d4a8c7238564f4d2f4f68116aca28c9b21341dc3a877679c14556192b2b2f5fe2c11d624e0894d308ff7b94bf6fd72aef1b41017ffe2572e99019d1c61963e68cd0ed67734a42cb333b808e3867cbe631937214e32e409fb1fa62fdb69d494c2530e64a40e417d6ee")]
+[assembly: InternalsVisibleTo("MongoDB.Driver.Encryption, PublicKey=002400000480000094000000060200000024000052534131000400000100010035287f0d3883c0a075c88e0cda3ce93b621003ecbd5e920d4a8c7238564f4d2f4f68116aca28c9b21341dc3a877679c14556192b2b2f5fe2c11d624e0894d308ff7b94bf6fd72aef1b41017ffe2572e99019d1c61963e68cd0ed67734a42cb333b808e3867cbe631937214e32e409fb1fa62fdb69d494c2530e64a40e417d6ee")]
+[assembly: InternalsVisibleTo("MongoDB.Driver.Authentication.AWS, PublicKey=002400000480000094000000060200000024000052534131000400000100010035287f0d3883c0a075c88e0cda3ce93b621003ecbd5e920d4a8c7238564f4d2f4f68116aca28c9b21341dc3a877679c14556192b2b2f5fe2c11d624e0894d308ff7b94bf6fd72aef1b41017ffe2572e99019d1c61963e68cd0ed67734a42cb333b808e3867cbe631937214e32e409fb1fa62fdb69d494c2530e64a40e417d6ee")]

src/MongoDB.Bson/Serialization/BsonClassMap.cs

@@ -117,6 +117,7 @@ public IEnumerable<BsonCreatorMap> CreatorMaps
             get { return _creatorMaps; }
         }
 
+        //DOMAIN-API This one should be removed, or become a method to get the convention registry/domain as input
         /// <summary>
         /// Gets the conventions used for auto mapping.
         /// </summary>
@@ -246,6 +247,7 @@ internal int ExtraElementsMemberMapIndex
             get { return _extraElementsMemberIndex; }
         }
 
+        //DOMAIN-API This is a utility method, it should not be public.
         // public static methods
         /// <summary>
         /// Gets the type of a member.

src/MongoDB.Bson/Serialization/BsonMemberMap.cs

@@ -296,11 +296,6 @@ obj is BsonMemberMap other &&
         /// <returns>The serializer.</returns>
         public IBsonSerializer GetSerializer() => GetSerializer(BsonSerializer.DefaultSerializationDomain);
 
-        /// <summary>
-        /// //TODO
-        /// </summary>
-        /// <param name="domain"></param>
-        /// <returns></returns>
         internal IBsonSerializer GetSerializer(IBsonSerializationDomain domain)
         {
             if (_serializer == null)

src/MongoDB.Bson/Serialization/Conventions/IDiscriminatorConvention.cs

@@ -45,6 +45,7 @@ public interface IDiscriminatorConvention
         BsonValue GetDiscriminator(Type nominalType, Type actualType);
     }
 
+    //DOMAIN-API These methods should be substitute the above methods in the interface
     internal interface IDiscriminatorConventionInternal : IDiscriminatorConvention
     {
         /// <summary>

src/MongoDB.Bson/Serialization/Conventions/IScalarDiscriminatorConvention.cs

@@ -27,6 +27,6 @@ public interface IScalarDiscriminatorConvention : IDiscriminatorConvention
         /// </summary>
         /// <param name="type">The type.</param>
         /// <returns>The discriminators.</returns>
-        BsonValue[] GetDiscriminatorsForTypeAndSubTypes(Type type);
+        BsonValue[] GetDiscriminatorsForTypeAndSubTypes(Type type);  //FP Need to fix this....
     }
 }

src/MongoDB.Bson/Serialization/Conventions/ScalarDiscriminatorConvention.cs

@@ -49,7 +49,7 @@ Type IDiscriminatorConventionInternal.GetActualType(IBsonReader bsonReader, Type
         /// <param name="actualType">The actual type.</param>
         /// <returns>The discriminator value.</returns>
         public override BsonValue GetDiscriminator(Type nominalType, Type actualType) =>
-            (this as IDiscriminatorConventionInternal).GetDiscriminator(nominalType, actualType, BsonSerializer.DefaultSerializationDomain);  //TODO method should not be used, remove it in the future
+            (this as IDiscriminatorConventionInternal).GetDiscriminator(nominalType, actualType, BsonSerializer.DefaultSerializationDomain);
 
         /// <inheritdoc />
         BsonValue IDiscriminatorConventionInternal.GetDiscriminator(Type nominalType, Type actualType, IBsonSerializationDomain domain)