Don't use DropDatabase in tests because it's slow and in some server versions causes unwanted elections.

Author: rstam

MongoDB.DriverUnitTests/Configuration.cs

@@ -46,7 +46,7 @@ static Configuration()
 
             __testClient = new MongoClient(clientSettings);
             __testServer = __testClient.GetServer();
-            __testDatabase = __testServer.GetDatabase(mongoUrl.DatabaseName ?? "csharpdriverunittests");
+            __testDatabase = __testServer.GetDatabase(GetDatabaseName(mongoUrl));
             __testCollection = __testDatabase.GetCollection("testcollection");
 
             // connect early so BuildInfo will be populated
@@ -159,6 +159,18 @@ public static IDisposable StopReplication(MongoServerInstance secondary)
             }
         }
 
+        // private methods
+        private static string GetDatabaseName(MongoUrl mongoUrl)
+        {
+            if (mongoUrl.DatabaseName != null)
+            {
+                return mongoUrl.DatabaseName;
+            }
+
+            var timestamp = DateTime.Now.ToString("MMddHHmm");
+            return "Tests" + timestamp;
+        }
+
         // nested types
         private class ReplicationRestarter : IDisposable
         {

MongoDB.DriverUnitTests/MongoDatabaseTests.cs

@@ -35,7 +35,6 @@ public void Setup()
             _server = Configuration.TestServer;
             _primary = Configuration.TestServer.Primary;
             _database = Configuration.TestDatabase;
-            _database.Drop();
         }
 
         // TODO: more tests for MongoDatabase
@@ -256,11 +255,12 @@ public void TestGetCollectionGeneric()
         [Test]
         public void TestGetCollectionNames()
         {
-            _database.Drop();
-            _database.GetCollection("a").Insert(new BsonDocument("a", 1));
-            _database.GetCollection("b").Insert(new BsonDocument("b", 1));
-            _database.GetCollection("c").Insert(new BsonDocument("c", 1));
-            var collectionNames = _database.GetCollectionNames();
+            var databaseName = Configuration.TestDatabase.Name + "-TestGetCollectionNames";
+            var database = _server.GetDatabase(databaseName);
+            database.GetCollection("a").Insert(new BsonDocument("a", 1));
+            database.GetCollection("b").Insert(new BsonDocument("b", 1));
+            database.GetCollection("c").Insert(new BsonDocument("c", 1));
+            var collectionNames = database.GetCollectionNames();
             Assert.AreEqual(new[] { "a", "b", "c" }, collectionNames.Where(n => n != "system.indexes"));
         }
 

MongoDB.DriverUnitTests/MongoServerTests.cs

@@ -27,7 +27,6 @@ public class MongoServerTests
         private MongoServer _server;
         private MongoDatabase _database;
         private MongoCollection<BsonDocument> _collection;
-        private bool _isMasterSlavePair;
         private bool _isReplicaSet;
 
         [TestFixtureSetUp]
@@ -37,11 +36,6 @@ public void Setup()
             _database = Configuration.TestDatabase;
             _collection = Configuration.TestCollection;
             _isReplicaSet = Configuration.TestServerIsReplicaSet;
-
-            var adminDatabase = _server.GetDatabase("admin");
-            var commandResult = adminDatabase.RunCommand("getCmdLineOpts");
-            var argv = commandResult.Response["argv"].AsBsonArray;
-            _isMasterSlavePair = argv.Contains("--master") || argv.Contains("--slave");
         }
 
         [Test]
@@ -100,28 +94,28 @@ public void TestCreateNoArgs()
         [Test]
         public void TestDatabaseExists()
         {
-            if (!_isMasterSlavePair)
-            {
-                _database.Drop();
-                Assert.IsFalse(_server.DatabaseExists(_database.Name));
-                _collection.Insert(new BsonDocument("x", 1));
-                Assert.IsTrue(_server.DatabaseExists(_database.Name));
-            }
+            var databaseName = Configuration.TestDatabase.Name + "-TestDatabaseExists";
+            var database = _server.GetDatabase(databaseName);
+            var collection = database.GetCollection("TestDatabaseExists");
+            Assert.IsFalse(_server.DatabaseExists(databaseName));
+            collection.Insert(new BsonDocument("x", 1));
+            Assert.IsTrue(_server.DatabaseExists(databaseName));
         }
 
         [Test]
+        [RequiresServer(ServerTypes = ServerTypes.Standalone)]
         public void TestDropDatabase()
         {
-            if (!_isMasterSlavePair)
-            {
-                _collection.Insert(new BsonDocument());
-                var databaseNames = _server.GetDatabaseNames();
-                Assert.IsTrue(databaseNames.Contains(_database.Name));
+            var databaseName = Configuration.TestDatabase.Name + "-TestDropDatabase";
+            var database = _server.GetDatabase(databaseName);
+            var collection = database.GetCollection("TestDropDatabase");
+            collection.Insert(new BsonDocument());
+            var databaseNames = _server.GetDatabaseNames();
+            Assert.IsTrue(databaseNames.Contains(databaseName));
 
-                var result = _server.DropDatabase(_database.Name);
-                databaseNames = _server.GetDatabaseNames();
-                Assert.IsFalse(databaseNames.Contains(_database.Name));
-            }
+            var result = _server.DropDatabase(databaseName);
+            databaseNames = _server.GetDatabaseNames();
+            Assert.IsFalse(databaseNames.Contains(databaseName));
         }
 
         [Test]