#1930 rename arguments, keep in line with the parent name

Author: Treggats

src/Relations/BelongsToMany.php

@@ -82,11 +82,11 @@ protected function setWhere()
     }
 
     /** @inheritdoc */
-    public function save(Model $model, array $joining = [], $touch = true)
+    public function save(Model $model, array $pivotAttributes = [], $touch = true)
     {
         $model->save(['touch' => false]);
 
-        $this->attach($model, $joining, $touch);
+        $this->attach($model, $pivotAttributes, $touch);
 
         return $model;
     }

src/Relations/EmbedsMany.php

@@ -322,13 +322,13 @@ protected function getEmbedded()
     }
 
     /** @inheritdoc */
-    protected function setEmbedded($models)
+    protected function setEmbedded($records)
     {
-        if (! is_array($models)) {
-            $models = [$models];
+        if (! is_array($records)) {
+            $records = [$records];
         }
 
-        return parent::setEmbedded(array_values($models));
+        return parent::setEmbedded(array_values($records));
     }
 
     /** @inheritdoc */

src/Schema/Blueprint.php

@@ -81,11 +81,11 @@ public function primary($columns = null, $name = null, $algorithm = null, $optio
     }
 
     /** @inheritdoc */
-    public function dropIndex($indexOrColumns = null)
+    public function dropIndex($index = null)
     {
-        $indexOrColumns = $this->transformColumns($indexOrColumns);
+        $index = $this->transformColumns($index);
 
-        $this->collection->dropIndex($indexOrColumns);
+        $this->collection->dropIndex($index);
 
         return $this;
     }
@@ -332,11 +332,11 @@ protected function fluent($columns = null)
      * Allows the use of unsupported schema methods.
      *
      * @param string $method
-     * @param array  $args
+     * @param array  $parameters
      *
      * @return Blueprint
      */
-    public function __call($method, $args)
+    public function __call($method, $parameters)
     {
         // Dummy.
         return $this;