Remove getHasCompareKey

Introduced by #1195

Author: GromNaN

src/Eloquent/HybridRelations.php

@@ -18,7 +18,6 @@
 
 use function debug_backtrace;
 use function is_subclass_of;
-use function method_exists;
 
 use const DEBUG_BACKTRACE_IGNORE_ARGS;
 

src/Helpers/QueriesRelationships.php

@@ -22,7 +22,6 @@
 use function in_array;
 use function is_array;
 use function is_string;
-use function method_exists;
 use function strpos;
 
 trait QueriesRelationships
@@ -114,23 +113,14 @@ public function addHybridHas(Relation $relation, $operator = '>=', $count = 1, $
             $not = ! $not;
         }
 
-        $relations = $hasQuery->pluck($this->getHasCompareKey($relation));
+        $key       = $relation instanceof HasOneOrMany ? $relation->getForeignKeyName() : $relation->getOwnerKeyName();
+        $relations = $hasQuery->pluck($key);
 
         $relatedIds = $this->getConstrainedRelatedIds($relations, $operator, $count);
 
         return $this->whereIn($this->getRelatedConstraintKey($relation), $relatedIds, $boolean, $not);
     }
 
-    /** @return string */
-    protected function getHasCompareKey(Relation $relation)
-    {
-        if (method_exists($relation, 'getHasCompareKey')) {
-            return $relation->getHasCompareKey();
-        }
-
-        return $relation instanceof HasOneOrMany ? $relation->getForeignKeyName() : $relation->getOwnerKeyName();
-    }
-
     /**
      * @param Collection $relations
      * @param string     $operator

src/Relations/BelongsTo.php

@@ -7,20 +7,8 @@
 use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Database\Eloquent\Model;
 
-use function property_exists;
-
 class BelongsTo extends \Illuminate\Database\Eloquent\Relations\BelongsTo
 {
-    /**
-     * Get the key for comparing against the parent key in "has" query.
-     *
-     * @return string
-     */
-    public function getHasCompareKey()
-    {
-        return $this->ownerKey;
-    }
-
     /** @inheritdoc */
     public function addConstraints()
     {

src/Relations/BelongsToMany.php

@@ -18,20 +18,9 @@
 use function count;
 use function is_array;
 use function is_numeric;
-use function property_exists;
 
 class BelongsToMany extends EloquentBelongsToMany
 {
-    /**
-     * Get the key for comparing against the parent key in "has" query.
-     *
-     * @return string
-     */
-    public function getHasCompareKey()
-    {
-        return $this->getForeignKey();
-    }
-
     /** @inheritdoc */
     public function getRelationExistenceQuery(Builder $query, Builder $parentQuery, $columns = ['*'])
     {

src/Relations/HasMany.php

@@ -20,20 +20,10 @@ public function getForeignKeyName()
         return $this->foreignKey;
     }
 
-    /**
-     * Get the key for comparing against the parent key in "has" query.
-     *
-     * @return string
-     */
-    public function getHasCompareKey()
-    {
-        return $this->getForeignKeyName();
-    }
-
     /** @inheritdoc */
     public function getRelationExistenceQuery(Builder $query, Builder $parentQuery, $columns = ['*'])
     {
-        $foreignKey = $this->getHasCompareKey();
+        $foreignKey = $this->getForeignKeyName();
 
         return $query->select($foreignKey)->where($foreignKey, 'exists', true);
     }

src/Relations/HasOne.php

@@ -20,16 +20,6 @@ public function getForeignKeyName()
         return $this->foreignKey;
     }
 
-    /**
-     * Get the key for comparing against the parent key in "has" query.
-     *
-     * @return string
-     */
-    public function getHasCompareKey()
-    {
-        return $this->getForeignKeyName();
-    }
-
     /** @inheritdoc */
     public function getRelationExistenceQuery(Builder $query, Builder $parentQuery, $columns = ['*'])
     {

src/Relations/MorphTo.php

@@ -7,8 +7,6 @@
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Relations\MorphTo as EloquentMorphTo;
 
-use function property_exists;
-
 class MorphTo extends EloquentMorphTo
 {
     /** @inheritdoc */