#1930 move parent constructor call down, removed duplicate assignments

Treggats · Treggats · commit e407ba529f17 · 2023-11-03T11:59:04.000+01:00
diff --git a/src/Relations/EmbedsOneOrMany.php b/src/Relations/EmbedsOneOrMany.php
@@ -43,10 +43,6 @@ abstract class EmbedsOneOrMany extends Relation
      */
     public function __construct(Builder $query, Model $parent, Model $related, string $localKey, string $foreignKey, string $relation)
     {
-        parent::__construct($query, $parent);
-
-        $this->query      = $query;
-        $this->parent     = $parent;
         $this->related    = $related;
         $this->localKey   = $localKey;
         $this->foreignKey = $foreignKey;
@@ -58,7 +54,7 @@ public function __construct(Builder $query, Model $parent, Model $related, strin
             $this->query = $parentRelation->getQuery();
         }
 
-        $this->addConstraints();
+        parent::__construct($query, $parent);
     }
 
     /** @inheritdoc */

Original file line number	Diff line number	Diff line change
`@@ -43,10 +43,6 @@ abstract class EmbedsOneOrMany extends Relation`
`43`	`43`	`*/`
`44`	`44`	`public function __construct(Builder $query, Model $parent, Model $related, string $localKey, string $foreignKey, string $relation)`
`45`	`45`	`{`
`46`		`- parent::__construct($query, $parent);`
`47`		`-`
`48`		`- $this->query = $query;`
`49`		`- $this->parent = $parent;`
`50`	`46`	`$this->related = $related;`
`51`	`47`	`$this->localKey = $localKey;`
`52`	`48`	`$this->foreignKey = $foreignKey;`
`@@ -58,7 +54,7 @@ public function __construct(Builder $query, Model $parent, Model $related, strin`
`58`	`54`	`$this->query = $parentRelation->getQuery();`
`59`	`55`	`}`
`60`	`56`
`61`		`- $this->addConstraints();`
	`57`	`+ parent::__construct($query, $parent);`
`62`	`58`	`}`
`63`	`59`
`64`	`60`	`/** @inheritdoc */`