Added modified protection to increments #97

Author: jenssegers

src/Jenssegers/Mongodb/Query/Builder.php

@@ -402,6 +402,13 @@ public function increment($column, $amount = 1, array $extra = array())
             $query['$set'] = $extra;
         }
 
+        // Protect
+        $this->where(function($query) use ($column)
+        {
+            $query->where($column, 'exists', false);
+            $query->orWhereNotNull($column);
+        });
+
         return $this->performUpdate($query);
     }
 

tests/QueryBuilderTest.php

@@ -511,6 +511,7 @@ public function testIncrement()
 		DB::collection('users')->insert(array(
 			array('name' => 'John Doe', 'age' => 30, 'note' => 'adult'),
 			array('name' => 'Jane Doe', 'age' => 10, 'note' => 'minor'),
+			array('name' => 'Robert Roe', 'age' => null),
 			array('name' => 'Mark Moe'),
 		));
 
@@ -548,6 +549,8 @@ public function testIncrement()
 		$this->assertEquals(11, $user['age']);
 		$user = DB::collection('users')->where('name', 'Jane Doe')->first();
 		$this->assertEquals(21, $user['age']);
+		$user = DB::collection('users')->where('name', 'Robert Roe')->first();
+		$this->assertEquals(null, $user['age']);
 		$user = DB::collection('users')->where('name', 'Mark Moe')->first();
 		$this->assertEquals(1, $user['age']);
 	}