replace array_merge with array unpacking

Author: Treggats

src/Relations/MorphToMany.php

@@ -85,11 +85,11 @@ protected function setWhere()
     }
 
     /** @inheritdoc */
-    public function save(Model $model, array $joining = [], $touch = true)
+    public function save(Model $model, array $pivotAttributes = [], $touch = true)
     {
         $model->save(['touch' => false]);
 
-        $this->attach($model, $joining, $touch);
+        $this->attach($model, $pivotAttributes, $touch);
 
         return $model;
     }
@@ -272,12 +272,13 @@ public function detach($ids = [], $touch = true)
             // Remove the relation from the parent.
             $data = [];
             foreach ($ids as $item) {
-                $data = array_merge($data, [
+                $data = [
+                    ...$data,
                     [
                         $this->relatedPivotKey => $item,
-                        $this->morphType       => $this->related->getMorphClass(),
+                        $this->morphType => $this->related->getMorphClass(),
                     ],
-                ]);
+                ];
             }
 
             $this->parent->pull($this->table, $data);
@@ -378,8 +379,8 @@ protected function whereInMethod(Model $model, $key)
     /**
      * Extract ids from given pivot table data
      *
-     * @param  array       $data
-     * @param  string|null $relatedPivotKey
+     * @param array       $data
+     * @param string|null $relatedPivotKey
      *
      * @return mixed
      */