#1930 update parameter type

Author: Treggats

src/Relations/EmbedsMany.php

@@ -9,6 +9,8 @@
 use Illuminate\Pagination\LengthAwarePaginator;
 use Illuminate\Pagination\Paginator;
 use MongoDB\BSON\ObjectID;
+use MongoDB\Driver\Exception\LogicException;
+use MongoDB\Laravel\Eloquent\Model as MongoDBModel;
 
 use function array_key_exists;
 use function array_values;
@@ -195,10 +197,15 @@ public function destroy($ids = [])
     /**
      * Delete all embedded models.
      *
-     * @return int
+     * @param null $id
+     *
+     * @throws LogicException|\Throwable
+     *
+     * @note The $id is not used to delete embedded models.
      */
-    public function delete()
+    public function delete($id = null): int
     {
+        throw_if($id !== null, new LogicException('The id parameter should not be used.'));
         // Overwrite the local key with an empty array.
         $result = $this->query->update([$this->localKey => []]);
 
@@ -224,9 +231,9 @@ public function detach($ids = [])
     /**
      * Save alias.
      *
-     * @return Model
+     * @return MongoDBModel
      */
-    public function attach(Model $model)
+    public function attach(MongoDBModel $model)
     {
         return $this->save($model);
     }

src/Relations/EmbedsOne.php

@@ -6,6 +6,10 @@
 
 use Illuminate\Database\Eloquent\Model;
 use MongoDB\BSON\ObjectID;
+use MongoDB\Driver\Exception\LogicException;
+use Throwable;
+
+use function throw_if;
 
 class EmbedsOne extends EmbedsOneOrMany
 {
@@ -133,10 +137,16 @@ public function dissociate()
     /**
      * Delete all embedded models.
      *
-     * @return int
+     * @param ?string $id
+     *
+     * @throws LogicException|Throwable
+     *
+     * @note The $id is not used to delete embedded models.
      */
-    public function delete()
+    public function delete($id = null): int
     {
+        throw_if($id !== null, new LogicException('The id parameter should not be used.'));
+
         return $this->performDelete();
     }
 

src/Relations/EmbedsOneOrMany.php

@@ -8,11 +8,15 @@
 use Illuminate\Database\Eloquent\Collection;
 use Illuminate\Database\Eloquent\Model as EloquentModel;
 use Illuminate\Database\Eloquent\Relations\Relation;
+use Illuminate\Database\Query\Expression;
+use MongoDB\Driver\Exception\LogicException;
 use MongoDB\Laravel\Eloquent\Model;
+use Throwable;
 
 use function array_merge;
 use function count;
 use function is_array;
+use function throw_if;
 
 abstract class EmbedsOneOrMany extends Relation
 {
@@ -99,10 +103,16 @@ public function get($columns = ['*'])
     /**
      * Get the number of embedded models.
      *
-     * @return int
+     * @param Expression|string $columns
+     *
+     * @throws LogicException|Throwable
+     *
+     * @note The $column parameter is not used to count embedded models.
      */
-    public function count()
+    public function count($columns = '*'): int
     {
+        throw_if($columns !== '*', new LogicException('The columns parameter should not be used.'));
+
         return count($this->getEmbedded());
     }
 
@@ -392,8 +402,8 @@ public function getQualifiedForeignKeyName()
     /**
      * Get the name of the "where in" method for eager loading.
      *
-     * @param  \Illuminate\Database\Eloquent\Model $model
-     * @param  string                              $key
+     * @param EloquentModel $model
+     * @param  string        $key
      *
      * @return string
      */