Don't add invalid regions to SARIF report (#3193)

Author: alcaeus

phpstan.neon.dist

@@ -13,7 +13,7 @@ parameters:
 
     ignoreErrors:
         - '#Unsafe usage of new static#'
-        - '#Call to an undefined method [a-zA-Z0-9\\_\<\>]+::[a-zA-Z]+\(\)#'
+        - '#Call to an undefined method [a-zA-Z0-9\\_\<\>\(\)]+::[a-zA-Z]+\(\)#'
 
 services:
     errorFormatter.sarif:

tests/PHPStan/SarifErrorFormatter.php

@@ -63,9 +63,6 @@ public function formatErrors(AnalysisResult $analysisResult, Output $output): in
                                 'uri' => $this->relativePathHelper->getRelativePath($fileSpecificError->getFile()),
                                 'uriBaseId' => self::URI_BASE_ID,
                             ],
-                            'region' => [
-                                'startLine' => $fileSpecificError->getLine(),
-                            ],
                         ],
                     ],
                 ],
@@ -78,6 +75,10 @@ public function formatErrors(AnalysisResult $analysisResult, Output $output): in
                 $result['properties']['tip'] = $fileSpecificError->getTip();
             }
 
+            if ($fileSpecificError->getLine() !== null) {
+                $result['locations'][0]['physicalLocation']['region']['startLine'] = $fileSpecificError->getLine();
+            }
+
             $results[] = $result;
         }