-
Notifications
You must be signed in to change notification settings - Fork 83
chore(ci): fix vscode test MONGOSH-2422 #2564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+41
−25
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a55b3db
chore(ci): fix vscode test
gagik 845f27b
chore: delete the 22.04 file
gagik 2bb714f
chore: fix build
gagik 90b7e7d
chore: fix setup
gagik 9baae5e
chore: remove setup env
gagik 17738f8
chore: pass the node version
gagik 9def5bb
chore: use expansions
gagik 513e8bd
chore: pass env explicitly?
gagik 21367c5
chore: use Node 22.19.0
gagik 72afe47
chore: set the latest VSCode node version to be based on the VSCode repo
gagik 3c44e68
chore: simplify dockerfile
gagik feb6fc8
chore: fallback if curl call fails
gagik 30a5271
chore: update actual config
gagik 5a1cd14
chore: update evergreen
gagik a721e4a
chore: use export
gagik 775ca29
chore: avoid NODE_JS_VERSION
gagik 0659eac
chore: avoid expansion syntax
gagik d37eaa4
chore: add --no-experimental-strip-types
gagik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| FROM ubuntu:24.04 | ||
|
|
||
| ARG NODE_JS_VERSION | ||
|
|
||
| RUN if [ -z "$NODE_JS_VERSION" ]; then echo "Error: NODE_JS_VERSION is not defined"; exit 1; fi | ||
|
|
||
| ENV NODE_JS_VERSION=${NODE_JS_VERSION} | ||
| ENV DEBIAN_FRONTEND=noninteractive | ||
| RUN apt-get update | ||
| RUN apt-get -y -qq install git curl apt-transport-https ca-certificates apt-utils software-properties-common | ||
|
|
||
| # Install Node.js using nvm (reusing pattern from .evergreen/install-node.sh) | ||
| ENV NVM_DIR="/root/.nvm" | ||
| RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/install.sh | bash && \ | ||
gagik marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| . "$NVM_DIR/nvm.sh" && \ | ||
| [ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion" && \ | ||
| nvm install --no-progress $NODE_JS_VERSION && \ | ||
| nvm alias default $NODE_JS_VERSION && \ | ||
| nvm use $NODE_JS_VERSION | ||
| # Set PATH so node/npm are available in all contexts | ||
| ENV PATH="$NVM_DIR/versions/node/v${NODE_JS_VERSION}/bin:$PATH" | ||
|
|
||
| # Install vscode dependencies | ||
| RUN apt-get -y -qq install libnss3 gnupg libxkbfile1 libsecret-1-0 libsecret-1-dev libgtk-3-0t64 libxss1 libgbm1 libasound2t64 xvfb build-essential pkg-config | ||
gagik marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ENTRYPOINT [ "bash" ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is VSCode still on this? I imagine we'd actually want a more recent one that roughly matches what VSCode uses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VSCode is pretty slow at adopting Node but the latest one is actually now on 22.19.0, so I can try this 👍