fixup: handle for-of/in lvalues, labels

Author: addaleax

packages/async-rewriter2/src/async-writer-babel.spec.ts

@@ -477,7 +477,7 @@ describe('AsyncWriter', function () {
       expect(implicitlyAsyncFn).to.have.callCount(10);
     });
 
-    it.skip('can use for loops as weird assignments (sync)', async function () {
+    it('can use for loops as weird assignments (sync)', async function () {
       const obj = { foo: null };
       implicitlyAsyncFn.resolves(obj);
       await runTranspiledCode(
@@ -487,7 +487,7 @@ describe('AsyncWriter', function () {
       expect(obj.foo).to.equal('bar');
     });
 
-    it.skip('can use for loops as weird assignments (async)', async function () {
+    it('can use for loops as weird assignments (async)', async function () {
       const obj = { foo: null };
       implicitlyAsyncFn.resolves(obj);
       await runTranspiledCode(

packages/async-rewriter3/src/lib.rs

@@ -1,6 +1,6 @@
 use std::{borrow::Borrow, collections::VecDeque, fmt::Debug};
 use wasm_bindgen::prelude::*;
-use rslint_parser::{ast::{ArrowExpr, AssignExpr, CallExpr, ClassDecl, Constructor, Expr, ExprOrBlock, ExprStmt, FnDecl, FnExpr, GroupingExpr, Literal, Method, NameRef, ObjectPatternProp, ParameterList, Pattern, PropName, ReturnStmt, ThisExpr, UnaryExpr, VarDecl}, parse_text, AstNode, SyntaxKind, SyntaxNode, TextSize};
+use rslint_parser::{ast::{ArrowExpr, AssignExpr, BreakStmt, CallExpr, ClassDecl, Constructor, ContinueStmt, Expr, ExprOrBlock, ExprStmt, FnDecl, FnExpr, ForInStmt, ForOfStmt, ForStmtInit, GroupingExpr, Literal, Method, NameRef, ObjectPatternProp, ParameterList, Pattern, PropName, ReturnStmt, ThisExpr, UnaryExpr, VarDecl}, parse_text, AstNode, SyntaxKind, SyntaxNode, TextSize};
 
 #[derive(Debug)]
 enum InsertionText {
@@ -378,7 +378,17 @@ fn collect_insertions(node: &SyntaxNode, nesting_depth: u32) -> InsertionList {
                     (is_unary_rhs && !is_typeof_rhs);
                 let is_argument_default_value = ParameterList::can_cast(as_expr.syntax().parent().unwrap().parent().unwrap().kind());
                 let is_literal = Literal::can_cast(as_expr.syntax().kind());
-                let wants_implicit_await_wrapper = !is_lhs_of_assign_expr && !is_argument_default_value && !is_eval_this_super_reference && !is_literal;
+                let is_label_in_continue_or_break = is_name_ref(as_expr.syntax(), None) &&
+                ContinueStmt::can_cast(as_expr.syntax().parent().unwrap().kind()) || BreakStmt::can_cast(as_expr.syntax().parent().unwrap().kind());
+                let is_for_in_of_lvalue =
+                ForStmtInit::can_cast(as_expr.syntax().parent().unwrap().kind());
+                let wants_implicit_await_wrapper =
+                    !is_lhs_of_assign_expr &&
+                    !is_argument_default_value &&
+                    !is_eval_this_super_reference &&
+                    !is_literal &&
+                    !is_label_in_continue_or_break &&
+                    !is_for_in_of_lvalue;
 
                 if is_named_typeof_rhs {
                     insertions.push_back(Insertion::new_dynamic(as_expr.syntax().parent().unwrap().text_range().start(), [