fix: address comments

Author: fmenezes

src/telemetry/telemetry.ts

@@ -49,7 +49,7 @@ async function isContainerized(): Promise<boolean> {
 
 export class Telemetry {
     /** Resolves when the device ID is retrieved or timeout occurs */
-    private bufferingEvents: number = 2;
+    private pendingPromises: number = 2;
     public deviceIdPromise: Promise<string> | undefined;
     public containerEnvPromise: Promise<boolean> | undefined;
     private deviceIdAbortController = new AbortController();
@@ -123,10 +123,10 @@ export class Telemetry {
             },
             abortSignal: this.deviceIdAbortController.signal,
         }).finally(() => {
-            this.bufferingEvents--;
+            this.pendingPromises--;
         });
         this.containerEnvPromise = this.getContainerEnv().finally(() => {
-            this.bufferingEvents--;
+            this.pendingPromises--;
         });
     }
 
@@ -192,16 +192,16 @@ export class Telemetry {
         return !doNotTrack;
     }
 
-    public isBufferingEvents(): boolean {
-        return this.bufferingEvents > 0;
+    public hasPendingPromises(): boolean {
+        return this.pendingPromises > 0;
     }
 
     /**
      * Attempts to emit events through authenticated and unauthenticated clients
      * Falls back to caching if both attempts fail
      */
     private async emit(events: BaseEvent[]): Promise<void> {
-        if (this.isBufferingEvents()) {
+        if (this.hasPendingPromises()) {
             this.eventCache.appendEvents(events);
             return;
         }

tests/integration/telemetry.test.ts

@@ -13,10 +13,10 @@ describe("Telemetry", () => {
             getContainerEnv: () => new Promise((resolve) => resolve(false)),
         });
 
-        expect(telemetry.isBufferingEvents()).toBe(true);
+        expect(telemetry.hasPendingPromises()).toBe(true);
         const commonProps = await telemetry.getAsyncCommonProperties();
 
         expect(commonProps.device_id).toBe(actualHashedId);
-        expect(telemetry.isBufferingEvents()).toBe(false);
+        expect(telemetry.hasPendingPromises()).toBe(false);
     });
 });

tests/unit/telemetry.test.ts

@@ -220,9 +220,9 @@ describe("Telemetry", () => {
                         getContainerEnv: () => Promise.resolve(false),
                     });
 
-                    expect(telemetry.isBufferingEvents()).toBe(true);
+                    expect(telemetry.hasPendingPromises()).toBe(true);
                     const commonProps = await telemetry.getAsyncCommonProperties();
-                    expect(telemetry.isBufferingEvents()).toBe(false);
+                    expect(telemetry.hasPendingPromises()).toBe(false);
                     expect(commonProps.device_id).toBe(hashedMachineId);
                 });
 
@@ -234,9 +234,9 @@ describe("Telemetry", () => {
                         getContainerEnv: () => Promise.resolve(false),
                     });
 
-                    expect(telemetry.isBufferingEvents()).toBe(true);
+                    expect(telemetry.hasPendingPromises()).toBe(true);
                     const commonProps = await telemetry.getAsyncCommonProperties();
-                    expect(telemetry.isBufferingEvents()).toBe(false);
+                    expect(telemetry.hasPendingPromises()).toBe(false);
                     expect(commonProps.device_id).toBe("unknown");
 
                     expect(loggerSpy).toHaveBeenCalledWith(
@@ -254,7 +254,7 @@ describe("Telemetry", () => {
                         getRawMachineId: () => new Promise(() => {}),
                         getContainerEnv: () => Promise.resolve(false),
                     });
-                    expect(telemetry.isBufferingEvents()).toBe(true);
+                    expect(telemetry.hasPendingPromises()).toBe(true);
                     jest.advanceTimersByTime(DEVICE_ID_TIMEOUT);
                     const commonProps = await telemetry.getAsyncCommonProperties();
                     expect(commonProps.device_id).toBe("unknown");