chore: get default user config from schema

Author: gagik

README.md

@@ -354,7 +354,7 @@ The MongoDB MCP Server can be configured using multiple methods, with the follow
 | `atlasTemporaryDatabaseUserLifetimeMs` | `MDB_MCP_ATLAS_TEMPORARY_DATABASE_USER_LIFETIME_MS` | `14400000`                                                                                             | Time in milliseconds that temporary database users created when connecting to MongoDB Atlas clusters will remain active before being automatically deleted.                                     |
 | `confirmationRequiredTools`            | `MDB_MCP_CONFIRMATION_REQUIRED_TOOLS`               | `"atlas-create-access-list,atlas-create-db-user,drop-database,drop-collection,delete-many,drop-index"` | Comma separated values of tool names that require user confirmation before execution. Requires the client to support elicitation.                                                               |
 | `connectionString`                     | `MDB_MCP_CONNECTION_STRING`                         | `<not set>`                                                                                            | MongoDB connection string for direct database connections. Optional, if not set, you'll need to call the connect tool before interacting with MongoDB data.                                     |
-| `disableEmbeddingsValidation`          | `MDB_MCP_DISABLE_EMBEDDINGS_VALIDATION`             | `false`                                                                                                | When set to true, disables validation of embeddings dimensions.                                                                                                                                 |
+| `disableEmbeddingsValidation`          | `MDB_MCP_DISABLE_EMBEDDINGS_VALIDATION`             | `<not set>`                                                                                            | When set to true, disables validation of embeddings dimensions.                                                                                                                                 |
 | `disabledTools`                        | `MDB_MCP_DISABLED_TOOLS`                            | `""`                                                                                                   | Comma separated values of tool names, operation types, and/or categories of tools that will be disabled.                                                                                        |
 | `exportCleanupIntervalMs`              | `MDB_MCP_EXPORT_CLEANUP_INTERVAL_MS`                | `120000`                                                                                               | Time in milliseconds between export cleanup cycles that remove expired export files.                                                                                                            |
 | `exportTimeoutMs`                      | `MDB_MCP_EXPORT_TIMEOUT_MS`                         | `300000`                                                                                               | Time in milliseconds after which an export is considered expired and eligible for cleanup.                                                                                                      |

src/common/config.ts

@@ -181,6 +181,21 @@ interface ConfigFieldMeta {
  */
 export const configRegistry = z4.registry<ConfigFieldMeta>();
 
+function getLocalDataPath(): string {
+    return process.platform === "win32"
+        ? path.join(process.env.LOCALAPPDATA || process.env.APPDATA || os.homedir(), "mongodb")
+        : path.join(os.homedir(), ".mongodb");
+}
+
+export function getLogPath(): string {
+    const logPath = path.join(getLocalDataPath(), "mongodb-mcp", ".app-logs");
+    return logPath;
+}
+
+export function getExportsPath(): string {
+    return path.join(getLocalDataPath(), "mongodb-mcp", "exports");
+}
+
 export const UserConfigSchema = z4.object({
     apiBaseUrl: z4.string().default("https://cloud.mongodb.com/"),
     apiClientId: z4
@@ -209,6 +224,7 @@ export const UserConfigSchema = z4.object({
         }),
     logPath: z4
         .string()
+        .default(getLogPath())
         .describe("Folder to store logs.")
         .register(configRegistry, { defaultValueDescription: "see below*" }),
     disabledTools: z4
@@ -282,6 +298,7 @@ export const UserConfigSchema = z4.object({
         ),
     exportsPath: z4
         .string()
+        .default(getExportsPath())
         .describe("Folder to store exported data files.")
         .register(configRegistry, { defaultValueDescription: "see below*" }),
     exportTimeoutMs: z4
@@ -327,53 +344,14 @@ export const UserConfigSchema = z4.object({
 export type PreviewFeature = z4.infer<typeof UserConfigSchema>["previewFeatures"][number];
 export type UserConfig = z4.infer<typeof UserConfigSchema> & CliOptions;
 
-export const defaultUserConfig: UserConfig = {
-    apiBaseUrl: "https://cloud.mongodb.com/",
-    logPath: getLogPath(),
-    exportsPath: getExportsPath(),
-    exportTimeoutMs: 5 * 60 * 1000, // 5 minutes
-    exportCleanupIntervalMs: 2 * 60 * 1000, // 2 minutes
-    disabledTools: [],
-    telemetry: "enabled",
-    readOnly: false,
-    indexCheck: false,
-    confirmationRequiredTools: [
-        "atlas-create-access-list",
-        "atlas-create-db-user",
-        "drop-database",
-        "drop-collection",
-        "delete-many",
-        "drop-index",
-    ],
-    transport: "stdio",
-    httpPort: 3000,
-    httpHost: "127.0.0.1",
-    loggers: ["disk", "mcp"],
-    idleTimeoutMs: 10 * 60 * 1000, // 10 minutes
-    notificationTimeoutMs: 9 * 60 * 1000, // 9 minutes
-    httpHeaders: {},
-    maxDocumentsPerQuery: 100, // By default, we only fetch a maximum 100 documents per query / aggregation
-    maxBytesPerQuery: 16 * 1024 * 1024, // By default, we only return ~16 mb of data per query / aggregation
-    atlasTemporaryDatabaseUserLifetimeMs: 4 * 60 * 60 * 1000, // 4 hours
-    voyageApiKey: "",
-    disableEmbeddingsValidation: false,
-    vectorSearchDimensions: 1024,
-    vectorSearchSimilarityFunction: "euclidean",
-    previewFeatures: [],
-};
+export const defaultUserConfig: UserConfig = UserConfigSchema.parse({});
 
 export const config = setupUserConfig({
     defaults: defaultUserConfig,
     cli: process.argv,
     env: process.env,
 });
 
-function getLocalDataPath(): string {
-    return process.platform === "win32"
-        ? path.join(process.env.LOCALAPPDATA || process.env.APPDATA || os.homedir(), "mongodb")
-        : path.join(os.homedir(), ".mongodb");
-}
-
 export type DriverOptions = ConnectionInfo["driverOptions"];
 export const defaultDriverOptions: DriverOptions = {
     readConcern: {
@@ -388,15 +366,6 @@ export const defaultDriverOptions: DriverOptions = {
     applyProxyToOIDC: true,
 };
 
-function getLogPath(): string {
-    const logPath = path.join(getLocalDataPath(), "mongodb-mcp", ".app-logs");
-    return logPath;
-}
-
-function getExportsPath(): string {
-    return path.join(getLocalDataPath(), "mongodb-mcp", "exports");
-}
-
 // Gets the config supplied by the user as environment variables. The variable names
 // are prefixed with `MDB_MCP_` and the keys match the UserConfig keys, but are converted
 // to SNAKE_UPPER_CASE.

tests/unit/common/config.test.ts

@@ -5,12 +5,55 @@ import {
     defaultUserConfig,
     registerKnownSecretsInRootKeychain,
     warnAboutDeprecatedOrUnknownCliArgs,
+    getLogPath,
+    getExportsPath,
 } from "../../../src/common/config.js";
 import type { CliOptions } from "@mongosh/arg-parser";
 import { Keychain } from "../../../src/common/keychain.js";
 import type { Secret } from "../../../src/common/keychain.js";
 
 describe("config", () => {
+    it("should generate defaults from UserConfigSchema that match expected values", () => {
+        // Expected hardcoded values (what we had before)
+        const expectedDefaults = {
+            apiBaseUrl: "https://cloud.mongodb.com/",
+            // eslint-disable-next-line @typescript-eslint/no-unsafe-call
+            logPath: getLogPath() as string,
+            // eslint-disable-next-line @typescript-eslint/no-unsafe-call
+            exportsPath: getExportsPath() as string,
+            exportTimeoutMs: 5 * 60 * 1000, // 5 minutes
+            exportCleanupIntervalMs: 2 * 60 * 1000, // 2 minutes
+            disabledTools: [],
+            telemetry: "enabled",
+            readOnly: false,
+            indexCheck: false,
+            confirmationRequiredTools: [
+                "atlas-create-access-list",
+                "atlas-create-db-user",
+                "drop-database",
+                "drop-collection",
+                "delete-many",
+                "drop-index",
+            ],
+            transport: "stdio",
+            httpPort: 3000,
+            httpHost: "127.0.0.1",
+            loggers: ["disk", "mcp"],
+            idleTimeoutMs: 10 * 60 * 1000, // 10 minutes
+            notificationTimeoutMs: 9 * 60 * 1000, // 9 minutes
+            httpHeaders: {},
+            maxDocumentsPerQuery: 100,
+            maxBytesPerQuery: 16 * 1024 * 1024, // ~16 mb
+            atlasTemporaryDatabaseUserLifetimeMs: 4 * 60 * 60 * 1000, // 4 hours
+            voyageApiKey: "",
+            vectorSearchDimensions: 1024,
+            vectorSearchSimilarityFunction: "euclidean",
+            previewFeatures: [],
+        };
+
+        expect(defaultUserConfig).toStrictEqual(expectedDefaults);
+    });
+
     describe("env var parsing", () => {
         describe("mongodb urls", () => {
             it("should not try to parse a multiple-host urls", () => {