Merge pull request #26 from mongodb-js/compass-6197-redact-password-without-string

fix(redact): handle empty username when redacting password COMPASS-6197

Author: gribnoysup

src/redact.ts

@@ -59,7 +59,7 @@ export function redactConnectionString(
   const R = replacementString; // alias for conciseness
   const replacements: ((uri: string) => string)[] = [
     // Username and password
-    uri => uri.replace(redactUsernames ? /(\/\/)(.*)(@)/g : /(\/\/[^@]+:)(.*)(@)/g, `$1${R}$3`),
+    uri => uri.replace(redactUsernames ? /(\/\/)(.*)(@)/g : /(\/\/[^@]*:)(.*)(@)/g, `$1${R}$3`),
     // AWS IAM Session Token as part of query parameter
     uri => uri.replace(/(AWS_SESSION_TOKEN(:|%3A))([^,&]+)/gi, `$1${R}`),
     // tlsCertificateKeyFilePassword query parameter

test/redact.ts

@@ -43,6 +43,12 @@ describe('redact credentials', () => {
         expect(redactConnectionString(`${protocol}://admin:tscat3ca1s@cats-data-sets-e08dy.mongodb.net/admin?proxyUsername=foo&proxyPassword=bar`, { replacementString: '****' }))
           .to.equal(`${protocol}://****@cats-data-sets-e08dy.mongodb.net/admin?proxyUsername=****&proxyPassword=****`);
       });
+
+      it('redacts credentials when username is empty', () => {
+        expect(
+          redactConnectionString(`${protocol}://:password@mongodb.net/`)
+        ).to.equal(`${protocol}://<credentials>@mongodb.net/`);
+      });
     });
 
     context('when url contains no credentials', () => {