tests

Author: mabaasit

packages/compass-data-modeling/src/utils/utils.spec.tsx

@@ -4,6 +4,7 @@ import {
   isRelationshipOfAField,
   isSameFieldOrAncestor,
   dualSourceHandlerDebounce,
+  isRelationshipInvalid,
 } from './utils';
 import type { Relationship } from '../services/data-model-storage';
 
@@ -135,3 +136,42 @@ describe('dualSourceHandlerDebounce', function () {
     expect(invocationCount).to.equal(3);
   });
 });
+
+describe('isRelationshipInvalid', function () {
+  it('should return true for relationships with missing namespaces', function () {
+    const relationship = {
+      relationship: [
+        { ns: '', fields: ['a'], cardinality: 1 },
+        { ns: 'db.coll2', fields: ['b'], cardinality: 1 },
+      ],
+    } as any;
+    expect(isRelationshipInvalid(relationship)).to.be.true;
+  });
+  it('should return true for relationships with no fields', function () {
+    const relationship = {
+      relationship: [
+        { ns: 'db.coll1', fields: undefined, cardinality: 1 },
+        { ns: 'db.coll2', cardinality: 1 },
+      ],
+    } as any;
+    expect(isRelationshipInvalid(relationship)).to.be.true;
+  });
+  it('should return true for relationships with empty fields', function () {
+    const relationship = {
+      relationship: [
+        { ns: 'db.coll1', fields: [], cardinality: 1 },
+        { ns: 'db.coll2', fields: [], cardinality: 1 },
+      ],
+    } as any;
+    expect(isRelationshipInvalid(relationship)).to.be.true;
+  });
+  it('should return false for relationships with correct namespaces and fields', function () {
+    const relationship = {
+      relationship: [
+        { ns: 'db.coll1', fields: ['_id'], cardinality: 1 },
+        { ns: 'db.coll2', fields: ['order_id'], cardinality: 1 },
+      ],
+    } as any;
+    expect(isRelationshipInvalid(relationship)).to.be.false;
+  });
+});

packages/compass-data-modeling/src/utils/utils.ts

@@ -99,11 +99,14 @@ export function getNamespaceRelationships(
 
 export function isRelationshipInvalid(relationship: Relationship): boolean {
   const [source, target] = relationship.relationship;
-  if (!source.ns || !target.ns || !source.fields || !target.fields) {
-    return true;
-  }
-
-  if (source.fields.length === 0 || target.fields.length === 0) {
+  if (
+    !source.ns ||
+    !target.ns ||
+    !source.fields ||
+    !target.fields ||
+    source.fields.length === 0 ||
+    target.fields.length === 0
+  ) {
     return true;
   }