Work around LG-5601

kraenhansen · kraenhansen · commit 6372568a6e98 · 2025-10-10T14:02:41.000+02:00
diff --git a/packages/compass-components/src/components/modals/confirmation-modal.tsx b/packages/compass-components/src/components/modals/confirmation-modal.tsx
@@ -14,7 +14,7 @@ function ConfirmationModal({
 >): React.ReactElement {
   return (
     <LeafyGreenConfirmationModal {...props}>
-      <Body as="div">{children}</Body>
+      {props.open && <Body as="div">{children}</Body>}
     </LeafyGreenConfirmationModal>
   );
 }
diff --git a/packages/compass-components/src/components/modals/marketing-modal.tsx b/packages/compass-components/src/components/modals/marketing-modal.tsx
@@ -11,7 +11,7 @@ function MarketingModal({
 }: React.ComponentProps<typeof LeafyGreenMarketingModal>): React.ReactElement {
   return (
     <LeafyGreenMarketingModal {...props}>
-      <Body as="div">{children}</Body>
+      {props.open && <Body as="div">{children}</Body>}
     </LeafyGreenMarketingModal>
   );
 }
diff --git a/packages/compass-components/src/components/modals/modal.tsx b/packages/compass-components/src/components/modals/modal.tsx
@@ -68,7 +68,8 @@ function UnwrappedModal({
       )}
       {...props}
     >
-      <Body as="div">{children}</Body>
+      {/* Rendering conditionally on `open` as a workaround for LG-5601 */}
+      {props.open && <Body as="div">{children}</Body>}
     </LeafyGreenModal>
   );
 }

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ function ConfirmationModal({`
`14`	`14`	`>): React.ReactElement {`
`15`	`15`	`return (`
`16`	`16`	`<LeafyGreenConfirmationModal {...props}>`
`17`		`- <Body as="div">{children}</Body>`
	`17`	`+ {props.open && <Body as="div">{children}</Body>}`
`18`	`18`	`</LeafyGreenConfirmationModal>`
`19`	`19`	`);`
`20`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ function MarketingModal({`
`11`	`11`	`}: React.ComponentProps<typeof LeafyGreenMarketingModal>): React.ReactElement {`
`12`	`12`	`return (`
`13`	`13`	`<LeafyGreenMarketingModal {...props}>`
`14`		`- <Body as="div">{children}</Body>`
	`14`	`+ {props.open && <Body as="div">{children}</Body>}`
`15`	`15`	`</LeafyGreenMarketingModal>`
`16`	`16`	`);`
`17`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,8 @@ function UnwrappedModal({`
`68`	`68`	`)}`
`69`	`69`	`{...props}`
`70`	`70`	`>`
`71`		`- <Body as="div">{children}</Body>`
	`71`	+ {/* Rendering conditionally on `open` as a workaround for LG-5601 */}
	`72`	`+ {props.open && <Body as="div">{children}</Body>}`
`72`	`73`	`</LeafyGreenModal>`
`73`	`74`	`);`
`74`	`75`	`}`