fix(connection-import-export): use getConnectionTitle() instead of fav name COMPASS-10038 (#7538)

We have not had the distinction between favorites and non-favorites for
a while now, so just using `getConnectionTitle()` is the right thing
to use for getting a good connection display name.

Author: addaleax

package-lock.json

@@ -51,6 +51,7 @@
   "dependencies": {
     "@mongodb-js/compass-components": "^1.57.1",
     "@mongodb-js/compass-connections": "^1.86.0",
+    "@mongodb-js/connection-info": "^0.22.0",
     "@mongodb-js/connection-storage": "^0.60.0",
     "compass-preferences-model": "^2.64.0",
     "hadron-ipc": "^3.5.21",

packages/compass-connection-import-export/package.json

@@ -261,11 +261,23 @@ describe('useExportConnections', function () {
             // expecting to include the non-favorite connections as well
             savedConnectionType: 'recent',
           },
+          {
+            id: 'id2',
+            connectionOptions: {
+              connectionString: 'mongodb://localhost:2021',
+            },
+            favorite: {
+              name: '',
+            },
+            // expecting to include the non-favorite connections as well
+            savedConnectionType: 'recent',
+          },
         ],
       }
     );
 
     expect(result.current.state.connectionList).to.deep.equal([
+      { id: 'id2', name: 'localhost:2021', selected: true },
       { id: 'id1', name: 'name1', selected: true },
     ]);
   });

packages/compass-connection-import-export/src/hooks/use-export-connections.spec.tsx

@@ -18,6 +18,7 @@ import type {
 } from './common';
 import { usePreference } from 'compass-preferences-model/provider';
 import { useConnectionsList } from '@mongodb-js/compass-connections/provider';
+import { getConnectionTitle } from '@mongodb-js/connection-info';
 
 type ExportConnectionsState = CommonImportExportState<ConnectionShortInfo> & {
   removeSecrets: boolean;
@@ -29,12 +30,12 @@ const INITIAL_STATE: Readonly<ExportConnectionsState> = Object.freeze({
 });
 
 function connectionInfosToConnectionShortInfos(
-  infos: Pick<ConnectionInfo, 'favorite' | 'id'>[],
+  infos: Pick<ConnectionInfo, 'favorite' | 'id' | 'connectionOptions'>[],
   existingShortInfoList?: ConnectionShortInfo[]
 ): ConnectionShortInfo[] {
   return infos.map((conn) => ({
     id: conn.id,
-    name: conn.favorite?.name ?? '',
+    name: getConnectionTitle(conn),
     selected:
       existingShortInfoList?.find(({ id }) => id === conn.id)?.selected ?? true,
   }));

packages/compass-connection-import-export/src/hooks/use-export-connections.ts

@@ -19,6 +19,7 @@ import {
   useConnectionActions,
   useConnectionsList,
 } from '@mongodb-js/compass-connections/provider';
+import { getConnectionTitle } from '@mongodb-js/connection-info';
 
 type ConnectionImportInfo = ConnectionShortInfo & {
   isExistingConnection: boolean;
@@ -59,10 +60,11 @@ async function loadFile(
     });
 
     for (const info of connections) {
-      if (info.favorite?.name) {
+      const name = getConnectionTitle(info);
+      if (name) {
         const isExistingConnection = existingConnectionIds.includes(info.id);
         connectionList.push({
-          name: info.favorite.name,
+          name,
           id: info.id,
           selected: !isExistingConnection,
           isExistingConnection,