chore(e2e): save a screenshot if there's an error when closing the welcome modal (#7552)

lerouxb · web-flow · commit 3b96c5481855 · 2025-11-11T14:33:46.000Z
* save a screenshot if there's an error when closing the welcome modal

* include name in the filename
diff --git a/packages/compass-e2e-tests/helpers/compass.ts b/packages/compass-e2e-tests/helpers/compass.ts
@@ -1173,7 +1173,14 @@ export async function init(
   }
 
   if (compass.needsCloseWelcomeModal) {
-    await browser.closeWelcomeModal();
+    try {
+      await browser.closeWelcomeModal();
+    } catch (err) {
+      await browser.screenshot(
+        screenshotPathName(`${name ?? 'init'}-close-welcome-modal`)
+      );
+      throw err;
+    }
   }
 
   return compass;

Original file line number	Diff line number	Diff line change
`@@ -1173,7 +1173,14 @@ export async function init(`
`1173`	`1173`	`}`
`1174`	`1174`
`1175`	`1175`	`if (compass.needsCloseWelcomeModal) {`
`1176`		`- await browser.closeWelcomeModal();`
	`1176`	`+ try {`
	`1177`	`+ await browser.closeWelcomeModal();`
	`1178`	`+ } catch (err) {`
	`1179`	`+ await browser.screenshot(`
	`1180`	+ screenshotPathName(`${name ?? 'init'}-close-welcome-modal`)
	`1181`	`+ );`
	`1182`	`+ throw err;`
	`1183`	`+ }`
`1177`	`1184`	`}`
`1178`	`1185`
`1179`	`1186`	`return compass;`