Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/generators/eslint-arch-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function generateArchitectureRules(architecture) {
overrides.push({
files: ['**/bin/*.js', '**/bin/**/*.js'],
rules: {
'max-lines': ['error', { max: maxFileLength.cli, skipBlankLines: true, skipComments: true }]
'max-lines': ['warn', { max: maxFileLength.cli, skipBlankLines: true, skipComments: true }]
}
});
}
Expand Down
9 changes: 8 additions & 1 deletion lib/generators/eslint-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,14 @@ function writeEslintConfig(cwd, cfg) {
: ' // AI-friendly\n \'complexity\': [\'warn\', 15],\n \'max-depth\': [\'warn\', 4],\n \'max-lines-per-function\': [\'warn\', 100],\n';

const content = `// Generated by eslint-plugin-ai-code-snifftest init\nimport js from '@eslint/js';\nimport globals from 'globals';\nimport aiSnifftest from 'eslint-plugin-ai-code-snifftest';\n\nexport default [\n js.configs.recommended,\n {\n files: ['**/*.js'],\n languageOptions: {\n globals: {\n ...globals.node\n }\n },\n plugins: { 'ai-code-snifftest': aiSnifftest },\n rules: {\n // Baseline\n 'no-unused-vars': ['warn', { argsIgnorePattern: '^_' }],\n 'no-undef': 'error',\n 'prefer-const': 'warn',\n 'no-var': 'error',\n // Consistency\n 'quotes': ['warn', 'single', { avoidEscape: true }],\n 'semi': ['warn', 'always'],\n 'eqeqeq': ['error', 'always'],\n${aiFriendlyRules} // Naming (basic)\n 'camelcase': ['error', { properties: 'always' }],\n // Domain-specific\n 'ai-code-snifftest/no-redundant-calculations': 'warn',\n 'ai-code-snifftest/no-equivalent-branches': 'warn',\n 'ai-code-snifftest/prefer-simpler-logic': 'warn',\n 'ai-code-snifftest/no-redundant-conditionals': 'warn',\n 'ai-code-snifftest/no-unnecessary-abstraction': 'warn',\n 'ai-code-snifftest/no-generic-names': 'warn',\n 'ai-code-snifftest/enforce-domain-terms': 'warn',${archRulesConfig}\n }\n }${archOverridesConfig}\n];\n`;
fs.writeFileSync(file, content);
// Warn-only output: convert all built-in "error" severities to "warn" in generated config
const out = content
.replace(/'no-undef': 'error'/g, "'no-undef': 'warn'")
.replace(/'no-var': 'error'/g, "'no-var': 'warn'")
.replace(/'eqeqeq': \['error', 'always'\]/g, "'eqeqeq': ['warn', 'always']")
.replace(/'camelcase': \['error', \{ properties: 'always' \}\]/g, "'camelcase': ['warn', { properties: 'always' }]");

fs.writeFileSync(file, out);
console.log(`Wrote ${file}`);
}

Expand Down
2 changes: 1 addition & 1 deletion tests/lib/generators/eslint-arch-config.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ describe('eslint-arch-config generator', function () {

assert.ok(cliOverride, 'Should have CLI override');
assert.ok(cliOverride.rules['max-lines']);
assert.strictEqual(cliOverride.rules['max-lines'][0], 'error'); // CLI is error, not warn
assert.strictEqual(cliOverride.rules['max-lines'][0], 'warn'); // CLI is warn in passive start
assert.strictEqual(cliOverride.rules['max-lines'][1].max, 100);
});

Expand Down
Loading