Skip to content

Commit a5da103

Browse files
ScriptedAlchemyScriptedAlchemy
committed
fix(module-federation): restore manifest react18 share configs
1 parent 1f621ea commit a5da103

File tree

6 files changed

+73
-36
lines changed

6 files changed

+73
-36
lines changed

‎apps/manifest-demo/3009-webpack-provider/webpack.config.js‎

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,21 @@ module.exports = composePlugins(
4949
shared: {
5050
lodash: {},
5151
antd: {},
52-
// Unify React across host/remotes, including JSX runtimes
53-
react: { singleton: true, requiredVersion: '^19.1.1' },
54-
'react-dom': { singleton: true, requiredVersion: '^19.1.1' },
55-
'react/jsx-runtime': { singleton: true, requiredVersion: '^19.1.1' },
56-
'react/jsx-dev-runtime': {
52+
'react/': {
5753
singleton: true,
58-
requiredVersion: '^19.1.1',
54+
requiredVersion: '^18.3.1',
55+
},
56+
react: {
57+
singleton: true,
58+
requiredVersion: '^18.3.1',
59+
},
60+
'react-dom': {
61+
singleton: true,
62+
requiredVersion: '^18.3.1',
63+
},
64+
'react-dom/': {
65+
singleton: true,
66+
requiredVersion: '^18.3.1',
5967
},
6068
},
6169
experiments: {

‎apps/manifest-demo/3010-rspack-provider/rspack.config.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,19 +98,19 @@ module.exports = composePlugins(
9898
antd: {},
9999
// 'react/': {
100100
// singleton: true,
101-
// requiredVersion: '^19.1.1',
101+
// requiredVersion: '^18.3.1',
102102
// },
103103
react: {
104104
singleton: true,
105-
requiredVersion: '^19.1.1',
105+
requiredVersion: '^18.3.1',
106106
},
107107
'react-dom': {
108108
singleton: true,
109-
requiredVersion: '^19.1.1',
109+
requiredVersion: '^18.3.1',
110110
},
111111
'react-dom/': {
112112
singleton: true,
113-
requiredVersion: '^19.1.1',
113+
requiredVersion: '^18.3.1',
114114
},
115115
},
116116
dataPrefetch: true,

‎apps/manifest-demo/3011-rspack-manifest-provider/rspack.config.js‎

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,13 +80,21 @@ module.exports = composePlugins(
8080
'./Component': './src/App.jsx',
8181
},
8282
shared: {
83-
// Unify React across host/remotes, including JSX runtimes
84-
react: { singleton: true, requiredVersion: '^19.1.1' },
85-
'react-dom': { singleton: true, requiredVersion: '^19.1.1' },
86-
'react/jsx-runtime': { singleton: true, requiredVersion: '^19.1.1' },
87-
'react/jsx-dev-runtime': {
83+
'react/': {
8884
singleton: true,
89-
requiredVersion: '^19.1.1',
85+
requiredVersion: '^18.3.1',
86+
},
87+
react: {
88+
singleton: true,
89+
requiredVersion: '^18.3.1',
90+
},
91+
'react-dom': {
92+
singleton: true,
93+
requiredVersion: '^18.3.1',
94+
},
95+
'react-dom/': {
96+
singleton: true,
97+
requiredVersion: '^18.3.1',
9098
},
9199
},
92100
experiments: {

‎apps/manifest-demo/3012-rspack-js-entry-provider/rspack.config.js‎

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,13 +80,21 @@ module.exports = composePlugins(
8080
'./Component': './src/App.jsx',
8181
},
8282
shared: {
83-
// Unify React across host/remotes, including JSX runtimes
84-
react: { singleton: true, requiredVersion: '^19.1.1' },
85-
'react-dom': { singleton: true, requiredVersion: '^19.1.1' },
86-
'react/jsx-runtime': { singleton: true, requiredVersion: '^19.1.1' },
87-
'react/jsx-dev-runtime': {
83+
'react/': {
8884
singleton: true,
89-
requiredVersion: '^19.1.1',
85+
requiredVersion: '^18.3.1',
86+
},
87+
react: {
88+
singleton: true,
89+
requiredVersion: '^18.3.1',
90+
},
91+
'react-dom': {
92+
singleton: true,
93+
requiredVersion: '^18.3.1',
94+
},
95+
'react-dom/': {
96+
singleton: true,
97+
requiredVersion: '^18.3.1',
9098
},
9199
},
92100
manifest: false,

‎apps/manifest-demo/webpack-host/webpack.config.js‎

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,21 @@ module.exports = composePlugins(withNx(), withReact(), (config, context) => {
3939
shared: {
4040
lodash: {},
4141
antd: {},
42-
// Unify React across host/remotes, including JSX runtimes
43-
react: { singleton: true, requiredVersion: '^19.1.1' },
44-
'react-dom': { singleton: true, requiredVersion: '^19.1.1' },
45-
'react/jsx-runtime': { singleton: true, requiredVersion: '^19.1.1' },
46-
'react/jsx-dev-runtime': {
42+
'react/': {
4743
singleton: true,
48-
requiredVersion: '^19.1.1',
44+
requiredVersion: '^18.3.1',
45+
},
46+
react: {
47+
singleton: true,
48+
requiredVersion: '^18.3.1',
49+
},
50+
'react-dom': {
51+
singleton: true,
52+
requiredVersion: '^18.3.1',
53+
},
54+
'react-dom/': {
55+
singleton: true,
56+
requiredVersion: '^18.3.1',
4957
},
5058
},
5159
dataPrefetch: true,

‎apps/modernjs/modern.config.ts‎

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export default defineConfig({
99
router: true,
1010
},
1111
security: {
12-
checkSyntax: false,
12+
checkSyntax: true,
1313
},
1414
source: {
1515
// downgrade @module-federation related pkgs
@@ -47,16 +47,21 @@ export default defineConfig({
4747
},
4848
filename: 'remoteEntry.js',
4949
shared: {
50-
// Unify React across host/remotes, including JSX runtimes
51-
react: { singleton: true, requiredVersion: '^19.1.1' },
52-
'react-dom': { singleton: true, requiredVersion: '^19.1.1' },
53-
'react/jsx-runtime': {
50+
'react/': {
5451
singleton: true,
55-
requiredVersion: '^19.1.1',
52+
requiredVersion: '^18.3.1',
5653
},
57-
'react/jsx-dev-runtime': {
54+
react: {
5855
singleton: true,
59-
requiredVersion: '^19.1.1',
56+
requiredVersion: '^18.3.1',
57+
},
58+
'react-dom': {
59+
singleton: true,
60+
requiredVersion: '^18.3.1',
61+
},
62+
'react-dom/': {
63+
singleton: true,
64+
requiredVersion: '^18.3.1',
6065
},
6166
},
6267
dataPrefetch: true,

0 commit comments

Comments
 (0)