Skip to content

Commit 639a83b

Browse files
chore: stabilize tsc rollup builds and clean up CI retries (#4105)
1 parent 8a80605 commit 639a83b

File tree

27 files changed

+103
-31
lines changed

27 files changed

+103
-31
lines changed

.changeset/wet-pants-sniff.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
---
2+
"@module-federation/cli": patch
3+
"@module-federation/data-prefetch": patch
4+
"@module-federation/error-codes": patch
5+
"@module-federation/managers": patch
6+
"@module-federation/manifest": patch
7+
"@module-federation/rsbuild-plugin": patch
8+
"@module-federation/rspack": patch
9+
"@module-federation/runtime": patch
10+
"@module-federation/runtime-core": patch
11+
"@module-federation/inject-external-runtime-core-plugin": patch
12+
"@module-federation/runtime-tools": patch
13+
"@module-federation/sdk": patch
14+
"@module-federation/utilities": patch
15+
"@module-federation/webpack-bundler-runtime": patch
16+
---
17+
18+
use TSC instead of SWC

.github/workflows/build-and-test.yml

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
run: pnpm install
5050

5151
- name: Clear Node Modules Cache
52-
run: rm -rf node_modules/.cache
52+
run: find . -maxdepth 6 -type d \( -name ".cache" -o -name ".modern-js" \) -exec rm -rf {} +
5353

5454
- name: Install Cypress
5555
# if: steps.browsers-cache.outputs.cache-hit != 'true'
@@ -87,18 +87,12 @@ jobs:
8787
run: npx nx run-many --targets=build --projects=tag:type:pkg --parallel=4
8888

8989
- name: Run Affected Test
90-
uses: nick-fields/retry@v3
91-
with:
92-
max_attempts: 2
93-
timeout_minutes: 10
94-
command: npx nx affected -t test --parallel=3 --exclude='*,!tag:type:pkg'
90+
timeout-minutes: 10
91+
run: npx nx affected -t test --parallel=3 --exclude='*,!tag:type:pkg'
9592

9693
- name: Run Affected Experimental Tests
97-
uses: nick-fields/retry@v3
98-
with:
99-
max_attempts: 2
100-
timeout_minutes: 10
101-
command: npx nx affected -t test:experiments --parallel=1 --exclude='*,!tag:type:pkg' --skip-nx-cache
94+
timeout-minutes: 10
95+
run: npx nx affected -t test:experiments --parallel=1 --exclude='*,!tag:type:pkg' --skip-nx-cache
10296

10397
e2e-modern:
10498
needs: checkout-install

.github/workflows/devtools.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
uses: nrwl/nx-set-shas@v3
4848

4949
- name: Install Dependencies
50-
run: pnpm install && rm -rf ./node_modules/.cache
50+
run: pnpm install && find . -maxdepth 6 -type d \( -name ".cache" -o -name ".modern-js" \) -exec rm -rf {} +
5151

5252
- name: Install Cypress
5353
run: npx cypress install
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import Button from 'antd/lib/button';
2-
import { version } from 'antd/package.json';
2+
import antdPackage from 'antd/package.json';
33
import stuff from './stuff.module.css';
4+
5+
const { version } = antdPackage;
46
export default function ButtonOldAnt() {
57
return <Button className={stuff.test}>Button from antd@{version}</Button>;
68
}

apps/manifest-demo/3010-rspack-provider/src/components/ButtonOldAnt.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
import Button from 'antd/lib/button';
2-
import { version } from 'antd/package.json';
2+
import antdPackage from 'antd/package.json';
33
import * as stuff from './stuff.module.css';
44

5+
const { version } = antdPackage;
6+
57
export default function ButtonOldAnt() {
68
return (
79
// @ts-ignore
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
import Button from 'antd/lib/button';
2-
import { version } from 'antd/package.json';
2+
import antdPackage from 'antd/package.json';
33
import stuff from './stuff.module.css';
44

5+
const { version } = antdPackage;
6+
57
export default function ButtonOldAnt() {
68
return <Button className={stuff.test}>Button from antd@{version}</Button>;
79
}
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
import Button from 'antd/lib/button';
2-
import { version } from 'antd/package.json';
2+
import antdPackage from 'antd/package.json';
33
import stuff from './stuff.module.css';
44

5+
const { version } = antdPackage;
6+
57
export default function ButtonOldAnt() {
68
return <Button className={stuff.test}>Button from antd@{version}</Button>;
79
}

apps/runtime-demo/3007-runtime-remote/src/components/ButtonOldAnt.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
import Button from 'antd/lib/button';
2-
import { version } from 'antd/package.json';
2+
import antdPackage from 'antd/package.json';
33
import stuff from './stuff.module.css';
44

5+
const { version } = antdPackage;
6+
57
export default function ButtonOldAnt() {
68
return (
79
<Button className={stuff['test-remote2'] + ' test-remote2'}>

packages/cli/project.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"assets": [],
1515
"project": "packages/cli/package.json",
1616
"rollupConfig": "packages/cli/rollup.config.js",
17-
"compiler": "swc",
17+
"compiler": "tsc",
1818
"format": ["cjs"],
1919
"generatePackageJson": false,
2020
"useLegacyTypescriptPlugin": false

packages/data-prefetch/project.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"assets": [],
1616
"project": "packages/data-prefetch/package.json",
1717
"rollupConfig": "packages/data-prefetch/rollup.config.cjs",
18-
"compiler": "swc",
18+
"compiler": "tsc",
1919
"format": ["cjs", "esm"],
2020
"generatePackageJson": false,
2121
"useLegacyTypescriptPlugin": false

0 commit comments

Comments
 (0)