Skip to content

Commit 3dde7df

Browse files
authored
fix(runtime-core): register share if not registered (#4145)
1 parent 6bddce5 commit 3dde7df

File tree

2 files changed

+19
-17
lines changed

2 files changed

+19
-17
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@module-federation/runtime-core': patch
3+
---
4+
5+
fix(runtime-core): register share if not registered

packages/runtime-core/src/shared/index.ts

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -83,22 +83,19 @@ export class SharedHandler {
8383
sharedKeys.forEach((sharedKey) => {
8484
const sharedVals = shareInfos[sharedKey];
8585
sharedVals.forEach((sharedVal) => {
86-
const registeredShared = getRegisteredShare(
87-
this.shareScopeMap,
88-
sharedKey,
89-
sharedVal,
90-
this.hooks.lifecycle.resolveShare,
91-
);
92-
if (!registeredShared && sharedVal && sharedVal.lib) {
93-
this.setShared({
94-
pkgName: sharedKey,
95-
lib: sharedVal.lib,
96-
get: sharedVal.get,
97-
loaded: true,
98-
shared: sharedVal,
99-
from: userOptions.name,
100-
});
101-
}
86+
sharedVal.scope.forEach((sc) => {
87+
const registeredShared = this.shareScopeMap[sc]?.[sharedKey];
88+
if (!registeredShared) {
89+
this.setShared({
90+
pkgName: sharedKey,
91+
lib: sharedVal.lib,
92+
get: sharedVal.get,
93+
loaded: sharedVal.loaded || Boolean(sharedVal.lib),
94+
shared: sharedVal,
95+
from: userOptions.name,
96+
});
97+
}
98+
});
10299
});
103100
});
104101

@@ -496,7 +493,7 @@ export class SharedHandler {
496493
if (!this.shareScopeMap[sc][pkgName][version]) {
497494
this.shareScopeMap[sc][pkgName][version] = {
498495
version,
499-
scope: ['default'],
496+
scope: [sc],
500497
...shareInfo,
501498
lib,
502499
loaded,

0 commit comments

Comments
 (0)