Improve users list

Author: modularcoder

README.md

@@ -49,42 +49,8 @@ Your app is ready to be deployed!
 
 See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information.
 
-### `yarn eject`
 
-**Note: this is a one-way operation. Once you `eject`, you can’t go back!**
 
-If you aren’t satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project.
+### ToDo:
 
-Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own.
-
-You don’t have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it.
-
-## Learn More
-
-You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started).
-
-To learn React, check out the [React documentation](https://reactjs.org/).
-
-### Code Splitting
-
-This section has moved here: https://facebook.github.io/create-react-app/docs/code-splitting
-
-### Analyzing the Bundle Size
-
-This section has moved here: https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size
-
-### Making a Progressive Web App
-
-This section has moved here: https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app
-
-### Advanced Configuration
-
-This section has moved here: https://facebook.github.io/create-react-app/docs/advanced-configuration
-
-### Deployment
-
-This section has moved here: https://facebook.github.io/create-react-app/docs/deployment
-
-### `yarn build` fails to minify
-
-This section has moved here: https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify
+- Migrate mocks to https://github.com/mswjs/msw

src/Administration/Users/UsersList/UsersListActions.js

@@ -9,6 +9,7 @@ import {
   // ArrowDropDown as IconDropDown,
   Add as IconNew,
   Search as IconSearch,
+  Clear as IconClear,
 } from '@material-ui/icons'
 
 // import usersListContext from './usersListContext'
@@ -22,32 +23,43 @@ const DashboardActions = () => {
     setSearch(event.target.value)
   }
 
+  const handelClickSearchClearButton = () => {
+    setSearch('')
+  }
+
   return (
     <div className={classes.root}>
       <div className={classes.search}>
         <div className={classes.searchIcon}>
           <IconSearch />
         </div>
         <InputBase
-          placeholder="Search…"
+          placeholder="Search users…"
           classes={{
             root: classes.searchInputRoot,
-            input: clsx(
-              classes.searchInputInput,
-              search && classes.searchInputInputActive,
-            ),
+            input: clsx(classes.searchInputInput, search && '-active'),
           }}
           inputProps={{ 'aria-label': 'search' }}
+          value={search}
           onChange={handleChangeSearchInput}
         />
+        {search && (
+          <div className={classes.searchButtonClear}>
+            <Tooltip title="Clear search">
+              <Button color="secondary" onClick={handelClickSearchClearButton}>
+                <IconClear />
+              </Button>
+            </Tooltip>
+          </div>
+        )}
       </div>
-      <Tooltip title="Create new">
+      <Tooltip title="Create new user">
         <Button color="secondary">
           <IconNew className={classes.iconNew} />
           New
         </Button>
       </Tooltip>
-      <Tooltip title="Filter">
+      <Tooltip title="Filter users">
         <Button color="secondary">
           <IconFilter />
         </Button>
@@ -63,7 +75,8 @@ const DashboardActions = () => {
 
 const useStyles = makeStyles(theme => ({
   root: {
-    color: theme.palette.secondary.main,
+    // color: theme.palette.secondary.main,
+    color: theme.palette.grey[600],
   },
   iconNew: {
     marginRight: 5,
@@ -93,18 +106,28 @@ const useStyles = makeStyles(theme => ({
     alignItems: 'center',
     justifyContent: 'center',
   },
+  searchButtonClear: {
+    position: 'absolute',
+    height: '100%',
+    top: 0,
+    right: 0,
+    display: 'flex',
+    alignItems: 'center',
+    justifyContent: 'center',
+  },
   searchInputRoot: {
     color: 'inherit',
   },
   searchInputInput: {
     padding: theme.spacing(1, 1, 1, 0),
     // vertical padding + font size from searchIcon
     paddingLeft: `calc(1em + ${theme.spacing(4)}px)`,
+    paddingRight: '2.2em',
     transition: theme.transitions.create('width'),
     width: '100%',
     [theme.breakpoints.up('sm')]: {
       width: '12ch',
-      '&:focus, &.active': {
+      '&:focus, &.-active': {
         width: '20ch',
       },
     },

src/_common/BasePageToolbar/BasePageToolbar.js

@@ -59,6 +59,7 @@ const useStyles = makeStyles(theme =>
     },
     titleContainer: {},
     actionsContainer: {
+      color: theme.palette.grey[600],
       display: 'flex',
       justifyContent: 'flex-end',
     },