2 vector

Author: TomSaw

src/modm/math/geometry/vector.hpp

@@ -77,30 +77,28 @@ class Vector : public std::array<T, N>
 	constexpr Vector()
 	{ this->fill(0); }
 
+	template <typename U>
+	requires std::convertible_to<U, T>
+	constexpr explicit Vector(U v)
+	{ this->fill(modm::round_smart<T, U>(v)); }
+
+	template <typename U>
+	constexpr Vector(const U (&arr)[N])
+	{ std::transform(std::begin(arr), std::end(arr), this->begin(), [] (U v) { return modm::round_smart<T, U>(v); }); }
+
 	/**
 	 * @brief 			Multi purpose constructor.
 	 *
-	 * @param args		scalars, Vectors and Arrays in your desired order
+	 * @param args		Scalar type(s), modm::Vector(s) or std::array(s) in any order
 	 */
 	template <class... Args>
 	constexpr Vector(Args... args)
 	{
-		// Is perfect forwarding required here?
+		// Not sure if perfect forwarding is required here !?
 		// assign<0>(std::forward<Args>(args)...);
 		assign<0>(args...);
 	}
 
-	template <typename U>
-	requires std::convertible_to<U, T>
-	constexpr explicit Vector(U v)
-	{ this->fill(modm::round_smart<T, U>(v)); }
-
-	template <typename U>
-	constexpr Vector(const U (&arr)[N])
-	{
-		std::transform(std::begin(arr), std::end(arr), this->begin(), [] (U v) { return modm::round_smart<T, U>(v); });
-	}
-
 	template<typename U>
 	[[deprecated("Use constructor instead!")]]
 	Vector<U, N> convert() const
@@ -157,7 +155,7 @@ class Vector : public std::array<T, N>
 	{
 		Vector<U, N> res;
 
-		// no clue why, but RVO / Loop unrolling is not applied for this ...
+		// no clue why, but RVO / Loop unrolling does not apply here ...
 		// std::transform(this->begin(), this->end(), other.begin(), res.begin(), Func{});
 
 		// ... but this optimizes perfectly.
@@ -183,7 +181,7 @@ class Vector : public std::array<T, N>
 	{
 		Vector<U, N> res;
 
-		// no clue why, but RVO / Loop unrolling is not applied for this ...
+		// no clue why, but RVO / Loop unrolling does not apply here ...
 		// std::transform(this->begin(), this->end(), res.begin(), Func{});
 
 		// ... but this optimizes perfectly.
@@ -209,7 +207,7 @@ class Vector : public std::array<T, N>
 	{
 		Vector<U, N> res;
 
-		// no clue why, but RVO / Loop unrolling is not applied for this ...
+		// no clue why, but RVO / Loop unrolling does not apply here ...
 		// std::transform(this->begin(), this->end(), res.begin(), Func{});
 
 		// ... but this optimizes perfectly.
@@ -430,7 +428,7 @@ class Vector : public std::array<T, N>
 	constexpr float getAngleTo(const Vector& other) const requires (N == 2)
 	{ return (other - *this).getAngle(); }
 
-	// TODO implement as operator+=(Angle phi), operator-=(Angle phi) instead ??
+	// TODO implement as operator+=(Angle phi), operator-=(Angle phi) ??
 	constexpr Vector& rotate(float phi) requires (N == 2)
 	{
 		const float c = std::cos(phi);