oc parser/transformer working (#249)

rough but it works. involved a few fixes upstream in devtools, record subfield order was getting scrambled and some v1 schema things were not getting converted to v2. and a few fixes here, mostly to allow the typed transformer to handle composites i.e. (lists of) records and unions. I think this should generalize pretty well but it needs cleanup/refactoring.

still need an inbound converter. right now we only support array conversion and haven't tried plugging it into the output of the loader.

Author: wpbonelli

flopy4/mf6/codec/reader/grammar/filters.py

@@ -18,14 +18,21 @@ def field_type(field: FieldV2) -> str:
 
 
 def record_child_type(field: FieldV2) -> str:
-    """Get the grammar type for a field within a record context."""
+    """
+    Get the grammar type for a field within a record context.
+
+    In records, string fields should use 'word' instead of 'string'
+    to avoid consuming the rest of the line (since string matches token+ NEWLINE).
+    """
     match field.type:
-        case t if t in ["string", "double", "integer"]:
+        case "string":
+            return "word"  # Use word for strings in records to match single tokens
+        case t if t in ["double", "integer"]:
             return t
         case "keyword":
             return ""
         case "union":
-            return ""  # keystrings generate their own union rules
+            return ""  # unions generate their own union rules
         case _:
             return field.type
 

flopy4/mf6/codec/reader/grammar/generated/chf-cdb.lark

@@ -4,6 +4,7 @@
 %import typed.double -> double
 %import typed.number -> number
 %import typed.string -> string
+%import typed.word -> word
 %import typed.array -> array
 %import typed.record -> record
 %import typed.NEWLINE -> NEWLINE
@@ -27,6 +28,6 @@ boundnames: "boundnames"i
 print_input: "print_input"i 
 print_flows: "print_flows"i 
 save_flows: "save_flows"i 
-obs_filerecord: "filein"i "obs6"i string
+obs_filerecord: "obs6"i "filein"i word
 maxbound: "maxbound"i integer
 stress_period_data: record+

flopy4/mf6/codec/reader/grammar/generated/chf-chd.lark

@@ -4,6 +4,7 @@
 %import typed.double -> double
 %import typed.number -> number
 %import typed.string -> string
+%import typed.word -> word
 %import typed.array -> array
 %import typed.record -> record
 %import typed.NEWLINE -> NEWLINE
@@ -28,7 +29,7 @@ boundnames: "boundnames"i
 print_input: "print_input"i 
 print_flows: "print_flows"i 
 save_flows: "save_flows"i 
-ts_filerecord: "ts6"i "filein"i string
-obs_filerecord: "filein"i "obs6"i string
+ts_filerecord: "ts6"i "filein"i word
+obs_filerecord: "obs6"i "filein"i word
 maxbound: "maxbound"i integer
 stress_period_data: record+

flopy4/mf6/codec/reader/grammar/generated/chf-cxs.lark

@@ -4,6 +4,7 @@
 %import typed.double -> double
 %import typed.number -> number
 %import typed.string -> string
+%import typed.word -> word
 %import typed.array -> array
 %import typed.record -> record
 %import typed.NEWLINE -> NEWLINE
@@ -26,5 +27,5 @@ crosssectiondata_fields: (crosssectiondata)*
 print_input: "print_input"i 
 nsections: "nsections"i integer
 npoints: "npoints"i integer
-packagedata: "packagedata"i recarray
-crosssectiondata: "crosssectiondata"i recarray
+packagedata: "packagedata"i list
+crosssectiondata: "crosssectiondata"i list

flopy4/mf6/codec/reader/grammar/generated/chf-dfw.lark

@@ -4,6 +4,7 @@
 %import typed.double -> double
 %import typed.number -> number
 %import typed.string -> string
+%import typed.word -> word
 %import typed.array -> array
 %import typed.record -> record
 %import typed.NEWLINE -> NEWLINE
@@ -25,7 +26,7 @@ time_conversion: "time_conversion"i double
 save_flows: "save_flows"i 
 print_flows: "print_flows"i 
 save_velocity: "save_velocity"i 
-obs_filerecord: "obs6"i "filein"i string
+obs_filerecord: "obs6"i "filein"i word
 export_array_ascii: "export_array_ascii"i 
 dev_swr_conductance: "dev_swr_conductance"i 
 manningsn: "manningsn"i array

flopy4/mf6/codec/reader/grammar/generated/chf-disv1d.lark

@@ -4,6 +4,7 @@
 %import typed.double -> double
 %import typed.number -> number
 %import typed.string -> string
+%import typed.word -> word
 %import typed.array -> array
 %import typed.record -> record
 %import typed.NEWLINE -> NEWLINE
@@ -27,7 +28,7 @@ vertices_fields: (vertices)*
 cell1d_fields: (cell1d)*
 length_units: "length_units"i string
 nogrb: "nogrb"i 
-grb_filerecord: "grb6"i "fileout"i string
+grb_filerecord: "grb6"i "fileout"i word
 xorigin: "xorigin"i double
 yorigin: "yorigin"i double
 angrot: "angrot"i double
@@ -38,5 +39,5 @@ nvert: "nvert"i integer
 width: "width"i array
 bottom: "bottom"i array
 idomain: "idomain"i array
-vertices: "vertices"i recarray
-cell1d: "cell1d"i recarray
+vertices: "vertices"i list
+cell1d: "cell1d"i list

flopy4/mf6/codec/reader/grammar/generated/chf-evp.lark

@@ -4,6 +4,7 @@
 %import typed.double -> double
 %import typed.number -> number
 %import typed.string -> string
+%import typed.word -> word
 %import typed.array -> array
 %import typed.record -> record
 %import typed.NEWLINE -> NEWLINE
@@ -28,7 +29,7 @@ boundnames: "boundnames"i
 print_input: "print_input"i 
 print_flows: "print_flows"i 
 save_flows: "save_flows"i 
-ts_filerecord: "ts6"i "filein"i string
-obs_filerecord: "filein"i "obs6"i string
+ts_filerecord: "ts6"i "filein"i word
+obs_filerecord: "obs6"i "filein"i word
 maxbound: "maxbound"i integer
 stress_period_data: record+

flopy4/mf6/codec/reader/grammar/generated/chf-flw.lark

@@ -4,6 +4,7 @@
 %import typed.double -> double
 %import typed.number -> number
 %import typed.string -> string
+%import typed.word -> word
 %import typed.array -> array
 %import typed.record -> record
 %import typed.NEWLINE -> NEWLINE
@@ -28,7 +29,7 @@ boundnames: "boundnames"i
 print_input: "print_input"i 
 print_flows: "print_flows"i 
 save_flows: "save_flows"i 
-ts_filerecord: "ts6"i "filein"i string
-obs_filerecord: "filein"i "obs6"i string
+ts_filerecord: "ts6"i "filein"i word
+obs_filerecord: "obs6"i "filein"i word
 maxbound: "maxbound"i integer
 stress_period_data: record+

flopy4/mf6/codec/reader/grammar/generated/chf-ic.lark

@@ -4,6 +4,7 @@
 %import typed.double -> double
 %import typed.number -> number
 %import typed.string -> string
+%import typed.word -> word
 %import typed.array -> array
 %import typed.record -> record
 %import typed.NEWLINE -> NEWLINE

flopy4/mf6/codec/reader/grammar/generated/chf-nam.lark

@@ -4,6 +4,7 @@
 %import typed.double -> double
 %import typed.number -> number
 %import typed.string -> string
+%import typed.word -> word
 %import typed.array -> array
 %import typed.record -> record
 %import typed.NEWLINE -> NEWLINE
@@ -24,4 +25,4 @@ print_input: "print_input"i
 print_flows: "print_flows"i 
 save_flows: "save_flows"i 
 newtonoptions: "newton"i "under_relaxation"i
-packages: "packages"i recarray
+packages: "packages"i list