Merge pull request #2911 from modernweb-dev/fix/dont-normalize-external-urls

thepassle · web-flow · commit 87566ad8d186 · 2025-03-25T15:52:50.000+01:00
fix: dont call path.join on external urls, it breaks them
diff --git a/.changeset/green-peas-sit.md b/.changeset/green-peas-sit.md
@@ -0,0 +1,5 @@
+---
+'@web/rollup-plugin-polyfills-loader': patch
+---
+
+dont path.join on external urls, it breaks them
diff --git a/packages/rollup-plugin-polyfills-loader/src/rollupPluginPolyfillsLoader.ts b/packages/rollup-plugin-polyfills-loader/src/rollupPluginPolyfillsLoader.ts
@@ -88,7 +88,9 @@ export function polyfillsLoader(pluginOptions: RollupPluginPolyfillsLoaderConfig
           // js files (incl. chunks) will always be in the root directory
           const pathToRoot = path.posix.dirname(importPath);
           for (const chunkPath of entrypoint.chunk.imports) {
-            const relativeChunkPath = normalize(path.posix.join(pathToRoot, chunkPath));
+            const relativeChunkPath = normalize(
+              chunkPath.startsWith('http') ? chunkPath : path.posix.join(pathToRoot, chunkPath),
+            );
             preloaded.push(relativeChunkPath);
           }
         }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@web/rollup-plugin-polyfills-loader': patch
 +---
++
 +dont path.join on external urls, it breaks them
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,9 @@ export function polyfillsLoader(pluginOptions: RollupPluginPolyfillsLoaderConfig`
`88`	`88`	`// js files (incl. chunks) will always be in the root directory`
`89`	`89`	`const pathToRoot = path.posix.dirname(importPath);`
`90`	`90`	`for (const chunkPath of entrypoint.chunk.imports) {`
`91`		`- const relativeChunkPath = normalize(path.posix.join(pathToRoot, chunkPath));`
	`91`	`+ const relativeChunkPath = normalize(`
	`92`	`+ chunkPath.startsWith('http') ? chunkPath : path.posix.join(pathToRoot, chunkPath),`
	`93`	`+ );`
`92`	`94`	`preloaded.push(relativeChunkPath);`
`93`	`95`	`}`
`94`	`96`	`}`