Skip to content

Commit 3715de4

Browse files
committed
ocaml: update to mirage 4.0
Some of the dependencies have been renamed (e.g. cstruct.lwt to cstruct-lwt). Signed-off-by: David Scott <dave@recoil.org>
1 parent 79c6a4d commit 3715de4

File tree

5 files changed

+26
-13
lines changed

5 files changed

+26
-13
lines changed

.circleci/config.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ jobs:
2727
- run: make test
2828
- run: brew install opam libev libffi pkg-config
2929
- run: opam init -v -n --comp="${OPAM_COMP}" --switch="${OPAM_COMP}" local "${OPAM_REPO}"
30+
# Needed until the packages are released in ocaml/opam-repository
31+
- run: opam pin add qcow.0.11.0 git://github.com/mirage/ocaml-qcow -n
32+
- run: opam pin add qcow-tool.0.11.0 git://github.com/mirage/ocaml-qcow -n
3033
- run: opam pin add hyperkit .
3134
- run: opam config exec -- make clean
3235
- run: opam config exec -- make all

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,9 @@ OCAML_C_SRC := \
105105
src/lib/mirage_block_c.c
106106

107107
OCAML_WHERE := $(shell ocamlc -where)
108-
OCAML_PACKS := cstruct cstruct.lwt io-page io-page.unix uri mirage-block \
108+
OCAML_PACKS := cstruct cstruct-lwt io-page io-page.unix uri mirage-block \
109109
mirage-block-unix qcow unix threads lwt lwt.unix logs logs.fmt \
110-
mirage-unix prometheus-app conduit-lwt cohttp.lwt
110+
mirage-unix prometheus-app conduit-lwt cohttp-lwt-unix
111111
OCAML_LDLIBS := -L $(OCAML_WHERE) \
112112
$(shell ocamlfind query cstruct)/cstruct.a \
113113
$(shell ocamlfind query cstruct)/libcstruct_stubs.a \
@@ -116,12 +116,12 @@ OCAML_LDLIBS := -L $(OCAML_WHERE) \
116116
$(shell ocamlfind query io-page-unix)/libio_page_unix_stubs.a \
117117
$(shell ocamlfind query lwt.unix)/liblwt_unix_stubs.a \
118118
$(shell ocamlfind query lwt.unix)/lwt_unix.a \
119-
$(shell ocamlfind query lwt.unix)/lwt.a \
119+
$(shell ocamlfind query lwt)/lwt.a \
120120
$(shell ocamlfind query threads)/libthreadsnat.a \
121121
$(shell ocamlfind query mirage-block-unix)/libmirage_block_unix_stubs.a \
122122
$(shell ocamlfind query base)/libbase_stubs.a \
123123
$(LIBEV) \
124-
-lasmrun -lbigarray -lunix
124+
-lasmrun -lunix
125125

126126
build/hyperkit.o: CFLAGS += -I$(OCAML_WHERE)
127127
endif

README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,10 @@ via `brew` and using `opam` to install the appropriate libraries:
3737

3838
$ brew install opam libev
3939
$ opam init
40-
$ eval `opam config env`
41-
$ opam install uri qcow.0.10.4 conduit.1.0.0 lwt.3.1.0 qcow-tool mirage-block-unix.2.9.0 conf-libev logs fmt mirage-unix prometheus-app
40+
$ eval `opam env`
41+
$ opam pin add qcow.0.11.0 git://github.com/mirage/ocaml-qcow -n
42+
$ opam pin add qcow-tool.0.11.0 git://github.com/mirage/ocaml-qcow -n
43+
$ opam install uri qcow.0.11.0 conduit.2.1.0 lwt.5.3.0 qcow-tool mirage-block-unix.2.12.0 conf-libev logs fmt mirage-unix prometheus-app
4244

4345
Notes:
4446

hyperkit.opam

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,24 @@
1-
opam-version: "1.2"
1+
opam-version: "2.0"
2+
maintainer: "dave@recoil.org"
3+
authors: [ "see github source" ]
4+
license: "BSD 2 clause"
5+
homepage: "https://github.com/moby/hyperkit"
6+
dev-repo: "git+https://github.com/moby/hyperkit.git"
7+
bug-reports: "https://github.com/moby/hyperkit/issues"
8+
doc: "https://github.com/moby/hyperkit"
29

310
depends: [
411
"uri"
5-
"qcow" {= "0.10.4"}
12+
"qcow" {= "0.11.0"}
613
"qcow-tool"
7-
"sha" {= "1.10"}
8-
"conduit" {= "1.0.0"}
9-
"lwt" {= "3.1.0"}
10-
"mirage-block-unix" {= "2.9.0"}
14+
"sha"
15+
"conduit" {= "2.1.0"}
16+
"lwt" {= "5.3.0"}
17+
"mirage-block-unix" {= "2.12.0"}
1118
"conf-libev"
1219
"logs"
1320
"fmt"
1421
"mirage-unix"
1522
"prometheus-app"
1623
]
24+
synopsis: "Uses the Hypervisor.framework on macOS to run Linux VMs"

src/lib/mirage_block_c.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ mirage_block_unregister_thread(){
2626
/* Convenience macro to cache the OCaml callback and immediately abort()
2727
if it can't be found -- this would indicate a fundamental linking error. */
2828
#define OCAML_NAMED_FUNCTION(name) \
29-
static value *fn = NULL; \
29+
static const value *fn = NULL; \
3030
if (fn == NULL) { \
3131
fn = caml_named_value(name); \
3232
} \

0 commit comments

Comments
 (0)