-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add QuSpin .lvm file loader and tests for MNE Raw object creation #13098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add the read_raw_quspin_lvm function to parse QuSpin N1 .lvm files, converting the data to an MNE Raw object. This includes handling the metadata (e.g., sensor channels, trigger channels, and units) and creating an appropriate Info object. Add a new test file, test_quspin.py, to verify the functionality of the read_raw_quspin_lvm function. The tests cover parsing of the .lvm file, correct handling of metadata, and creation of an appropriate MNE Raw object. - Added quspin.py with read_raw_quspin_lvm function - Added __init__.py to initialize the quspin module - Added test_quspin.py with unit tests for QuSpin loader - Added quspin_N1_test_data.lvm, a small sample dataset for testing
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
for more information, see https://pre-commit.ci
| @@ -0,0 +1,62 @@ | |||
| LabVIEW Measurement | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have moved away from storing test data in MNE-Python, could you add the file to https://github.com/mne-tools/mne-testing-data ?
|
I'll give the code a more in-depth review soon, but in the meantime just a comment above about moving the test file ☝️ . If it's unclear what you need to do from the README in that repo I can help! |
|
Hi Eric,
Thanks for the feedback! I'll create PR with the quspin test data following
the instructions in the ReadMe. Will reach out if I hit any snags
(expecting to since I'm quite new to contributing -- appreciate your
patience in the meantime!)
Best regards,
Dave
…On Mon, Feb 3, 2025 at 12:16 PM Eric Larson ***@***.***> wrote:
I'll give the code a more in-depth review soon, but in the meantime just a
comment above about moving the test file ☝️ . If it's unclear what you need
to do from the README in that repo I can help!
—
Reply to this email directly, view it on GitHub
<#13098 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLLYAB5IRHGP7DSAGGNIZ3L2N66CLAVCNFSM6AAAAABWMZ5WSOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMZRHA3DENZRGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
David C. Bobela
Physicist, QuSpin Inc.,
331 South 104th Street, Suite 130
Louisville, CO 80027
Ph: 720-982-8807
Email: ***@***.*** ***@***.***>
Website: http://www.quspin.com/
|
|
@dbobela406 do you have time to come back to this one? Would it help for me to push some commits to get test data working etc.? |
|
Hi Eric,
I've been pulled into other directions and won't be able to follow up.
Since this commit we changed tact--we wrote our own FIFF converter that
will convert our datastream directly to FIFF. Doing so makes this effort
moot, since the QuSpin user can go directly to the MNE universe without
calling a specialized function within MNE. Therefore, you can close this
pull request without any further action from my side.
Best regards,
Dave
…On Wed, Nov 5, 2025 at 11:48 AM Eric Larson ***@***.***> wrote:
*larsoner* left a comment (mne-tools/mne-python#13098)
<#13098 (comment)>
@dbobela406 <https://github.com/dbobela406> do you have time to come back
to this one? Would it help for me to push some commits to get test data
working etc.?
—
Reply to this email directly, view it on GitHub
<#13098 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLLYAB5KGAEHCWLF66GIT4333JA7JAVCNFSM6AAAAACLH3OZXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIOJSG44TMOBSGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
David C. Bobela
Physicist, QuSpin Inc.,
331 South 104th Street, Suite 130
Louisville, CO 80027
Ph: 720-982-8807
Email: ***@***.*** ***@***.***>
Website: http://www.quspin.com/
|
|
Okay that works, thanks for the update @dbobela406 ! |
Reference issue (if any)
Addresses issue #12881
What does this implement/fix?
This pull request introduces the read_raw_quspin_lvm function to handle .lvm files generated by the QuSpin N1 system. The function reads and parses the .lvm file, converts the data to an MNE Raw object, and creates the corresponding Info object. Additionally, tests and sample data are included to validate the loader's functionality. Specific changes are:
Additional information