escape hatch e2e tests

Author: mnahkies

e2e/src/express.entrypoint.ts

@@ -1,5 +1,6 @@
 import {type NextFunction, type Request, type Response, Router} from "express"
 import {bootstrap} from "./generated/server/express"
+import {createEscapeHatchesRouter} from "./routes/express/escape-hatches"
 import {createRequestHeadersRouter} from "./routes/express/request-headers"
 import {createValidationRouter} from "./routes/express/validation"
 import {createErrorResponse} from "./shared"
@@ -9,9 +10,11 @@ function createRouter() {
 
   const requestHeadersRouter = createRequestHeadersRouter()
   const validationRouter = createValidationRouter()
+  const escapeHatchesRouter = createEscapeHatchesRouter()
 
   router.use(requestHeadersRouter)
   router.use(validationRouter)
+  router.use(escapeHatchesRouter)
 
   return router
 }

e2e/src/generated/server/express/routes/escape-hatches.ts

@@ -0,0 +1,26 @@
+import {SkipResponse} from "@nahkies/typescript-express-runtime/server"
+import {
+  type GetEscapeHatchesPlainText,
+  createRouter,
+} from "../../generated/server/express/routes/escape-hatches"
+
+const getEscapeHatchesPlainText: GetEscapeHatchesPlainText = async (
+  _,
+  respond,
+  req,
+  res,
+) => {
+  res.setHeader("x-ratelimit-remaining", "100")
+  res.status(200).send("Plain text response")
+
+  // TODO: the typescript types are correct, but gets mangled by json serialization
+  // return respond.with200().body("Plain text response")
+
+  return SkipResponse
+}
+
+export function createEscapeHatchesRouter() {
+  return createRouter({
+    getEscapeHatchesPlainText,
+  })
+}

e2e/src/generated/server/express/routes/request-headers.ts

@@ -1,3 +1,4 @@
+import type {ExpressRuntimeResponse} from "@nahkies/typescript-express-runtime/server"
 import {
   type GetResponses500,
   type GetResponsesEmpty,

e2e/src/generated/server/express/routes/validation.ts

@@ -1,7 +1,12 @@
+import {ExpressRuntimeError} from "@nahkies/typescript-express-runtime/errors"
 import {KoaRuntimeError} from "@nahkies/typescript-koa-runtime/errors"
 
 export function createErrorResponse(err: unknown) {
-  if (KoaRuntimeError.isKoaError(err) && err.phase !== "request_handler") {
+  if (
+    (KoaRuntimeError.isKoaError(err) ||
+      ExpressRuntimeError.isExpressError(err)) &&
+    err.phase !== "request_handler"
+  ) {
     return {
       status: 400,
       body: {