Skip to content

Commit f9d3d3a

Browse files
author
jared
committed
Improved documentation in extras/lbf-nix/lbf-typescript.nix
1 parent 15ac42b commit f9d3d3a

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

extras/lbf-nix/lbf-typescript.nix

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,11 @@ lbfTypescriptOpts@{
2626
, classes ? [ ]
2727
, # npmExtraDependencies are tarballs from `npm pack` of the dependencies required
2828
npmExtraDependencies ? [ ]
29-
# , # npmDevDependencies are tarballs from `npm pack` of the develoepr dependencies for building the project
30-
# # TODO(jaredponn): actually use this
31-
# npmDevDependencies ? [ ]
29+
# , # npmExtraDevDependencies are tarballs from `npm pack` of the developer dependencies for building the project
30+
# # TODO(jaredponn): actually use this later? For now, it seems okay that
31+
# # we only have project dependencies. This will need updates in
32+
# # [flake-lang.nix](https://github.com/mlabs-haskell/flake-lang.nix) as well.
33+
# npmExtraDevDependencies ? [ ]
3234
, configs ? [ ]
3335
, # Name of the package and also the name of the Cabal package.
3436
# Examples: name = "lbf-myproject"
@@ -83,8 +85,6 @@ lbfTypescriptOpts@{
8385
let
8486
lbf-build = import ./lbf-build.nix pkgs lbf;
8587

86-
# TODO(jaredponn): this was (essentially) stolen from the Rust side. This
87-
# should be made a common function.
8888
lbfListModules = pkgs.callPackage ./lbf-list-modules.nix { };
8989

9090
packageSet =
@@ -143,6 +143,7 @@ let
143143
# TODO(jaredponn): urgh, this was manually copy pastad in by hand.. automate
144144
# this more nicely later... there's a huge pain point with how this needs to
145145
# hit the network to create the package-lock.json...
146+
# Perhaps this should be included in the `npmExtraDependencies` field?
146147
packageJsonLockTemplate = with lbfTypescriptOpts;
147148
pkgs.writeTextFile {
148149
name = "lambda-buffers-package-lock-template";
@@ -205,7 +206,6 @@ let
205206
buildPhase =
206207
''
207208
export HOME=$(mktemp -d)
208-
# TODO(jaredponn): remove these symlinks
209209
ln -s ${lbfBuilt} autogen;
210210
ln -s ${lbfBuilt.workdir} .work-dir;
211211
ln -s ${lbfBuilt.buildjson} build.json;

0 commit comments

Comments
 (0)