Skip to content

Commit 1cd1494

Browse files
author
jared
committed
Changed denofmt and denolint to my-denofmt and my-denolint
in effort to fix CI problems
1 parent 160dc33 commit 1cd1494

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

extras/pre-commit-hooks-extra.nix

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,21 @@
1717
files = "\\.rs$";
1818
};
1919

20-
denofmt =
20+
# TODO(jaredponn): Why do we use our strange version of `denofmt` and
21+
# `denolint`? The default implemented version in `pre-commit-hooks.nix`
22+
# is a bit buggy (see
23+
# https://github.com/cachix/pre-commit-hooks.nix/issues/374), and the
24+
# latest version of `deno` on nix doesn't allow explicitly applying
25+
# the formatter to specific files
26+
my-denofmt =
2127
{
2228
name = "denofmt";
2329
description = "Format Typescript code.";
2430
entry = "${deno}/bin/deno fmt";
2531
files = "(\\.ts$)|(^tsconfig?(-base)\\.json$)";
2632
};
2733

28-
denolint =
34+
my-denolint =
2935
{
3036
name = "denolint";
3137
description = "Lint Typescript code.";

pre-commit.nix

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@
3636
dhall-format.enable = true;
3737
purty.enable = true;
3838
rustfmt-monorepo.enable = true;
39-
denofmt.enable = true;
40-
denolint.enable = true;
39+
my-denofmt.enable = true;
40+
my-denolint.enable = true;
4141

4242
} // (inputs.protobufs-nix.lib.${system}.preCommitHooks { inherit pkgs; });
4343

0 commit comments

Comments
 (0)