fix typo and other improvements

Author: IAmPara0x

src/BotPlutusInterface/Collateral.hs

@@ -15,7 +15,7 @@ import BotPlutusInterface.Types (
   unCollateralVar,
  )
 import Cardano.Prelude (Void)
-import Control.Concurrent.STM (atomically, modifyTVar', readTVarIO)
+import Control.Concurrent.STM (atomically, writeTVar, readTVarIO)
 import Data.Kind (Type)
 import Data.Map (Map)
 import Data.Map qualified as Map
@@ -30,7 +30,7 @@ getInMemCollateral = readTVarIO . unCollateralVar . ceCollateral
 setInMemCollateral :: forall (w :: Type). ContractEnvironment w -> CollateralUtxo -> IO ()
 setInMemCollateral cEnv txOutRef = do
   let cVar = unCollateralVar $ ceCollateral cEnv
-  atomically $ modifyTVar' cVar (const (Just txOutRef))
+  atomically $ writeTVar cVar (Just txOutRef)
 
 mkCollateralTx :: PABConfig -> Either Constraints.MkTxError Constraints.UnbalancedTx
 mkCollateralTx pabConf = Constraints.mkTx @Void mempty txc

src/BotPlutusInterface/Contract.hs

@@ -51,7 +51,7 @@ import Control.Monad.Trans.Either (EitherT, eitherT, firstEitherT, hoistEither,
 import Control.Monad.Trans.Except (ExceptT, throwE)
 import Data.Aeson (ToJSON, Value (Array, Bool, Null, Number, Object, String))
 import Data.Aeson.Extras (encodeByteString)
-import Data.Either.Combinators (maybeToRight, swapEither)
+import Data.Either.Combinators (maybeToLeft, swapEither)
 import Data.Function (fix)
 import Data.HashMap.Strict qualified as HM
 import Data.Kind (Type)
@@ -452,7 +452,7 @@ handleCollateral cEnv = do
     do
       collateralNotInMem <-
         newEitherT $
-          swapEither . maybeToRight "Collateral UTxO not found in contract env."
+        maybeToLeft "Collateral UTxO not found in contract env."
             <$> getInMemCollateral @w
 
       helperLog collateralNotInMem
@@ -463,7 +463,7 @@ handleCollateral cEnv = do
         ("Collateral UTxO not found or failed to be found in wallet: " <> pretty collateralNotInWallet)
 
       helperLog "Creating collateral UTxO."
-      --
+
       notCreatedCollateral <- newEitherT $ swapEither <$> makeCollateral @w cEnv
 
       helperLog
@@ -520,12 +520,12 @@ findCollateralAtOwnPKH cEnv =
           changeAddr =
             Ledger.pubKeyHashAddress
               (PaymentPubKeyHash pabConf.pcOwnPubKeyHash)
-              (pabConf.pcOwnStakePubKeyHash)
+              pabConf.pcOwnStakePubKeyHash
 
       r <- newEitherT $ CardanoCLI.utxosAt @w pabConf changeAddr
       let refsAndOuts = Map.toList $ Tx.toTxOut <$> r
       hoistEither $ case filter check refsAndOuts of
-        [] -> Left "Couldn't find colalteral UTxO"
+        [] -> Left "Couldn't find collateral UTxO"
         ((oref, _) : _) -> Right oref
   where
     check (_, txOut) = Tx.txOutValue txOut == collateralValue (cePABConfig cEnv)